git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sangeeta <sangunb09@gmail.com>
To: Eric Sunshine <sunshine@sunshineco.com>
Cc: Philippe Blain <levraiphilippeblain@gmail.com>,
	Git List <git@vger.kernel.org>,
	Kaartic Sivaraam <kaartic.sivaraam@gmail.com>,
	Christian Couder <christian.couder@gmail.com>,
	Lars Schneider <larsxschneider@gmail.com>,
	Johannes Schindelin <johannes.schindelin@gmx.de>
Subject: Re: Perf lib sanity tests fail on OSX
Date: Tue, 22 Dec 2020 10:53:23 +0530	[thread overview]
Message-ID: <CAHjREB6y_zr-TrEsQu5MpwegpSHg_5XxWLf0O_HFRrSg+sFvQg@mail.gmail.com> (raw)
In-Reply-To: <CAPig+cSh0L3RniJpEs3oddkzPGUyw5Ud39SAbYFoxwtBowLiaQ@mail.gmail.com>

Hey Philippe and Eric,

Thanks for the workaround and the patch. The perf tests are now passing.

Thanks and regards,
Sangeeta

On Wed, Dec 16, 2020 at 1:14 PM Eric Sunshine <sunshine@sunshineco.com> wrote:
>
> On Tue, Dec 15, 2020 at 9:19 PM Philippe Blain
> <levraiphilippeblain@gmail.com> wrote:
> > Le 2020-12-15 à 14:08, Sangeeta a écrit :
> > > The performance test, p0000-perf-lib-sanity.sh[1], is failing on my
> > > local OSX machine due to an error in the test_export of the foo
> > > variable. [...]
> >
> > It is not the export per se that fails (that would be very bad news
> > indeed), it is the shell magic in the 'test_run_perf_' function in
> > 'perf-lib.sh' that uses a non-portable sed(1) invocation:
> >
> > As you might already know, since macOS has some BSD background/ancestry,
> > most POSIX utilities are closer to the OpenBSD/FreeBSD versions than to
> > their GNU/Linux counterparts.
> >
> > I do not know sed syntax enough to fix the invocation to make it
> > portable (nor do I know if it's possible).
>
> A patch fixing the problem (correctly diagnosed by Philippe as
> non-portable `sed` usage) has been posted[1].
>
> [1]: https://lore.kernel.org/git/20201216073907.62591-1-sunshine@sunshineco.com/

      reply	other threads:[~2020-12-22  5:24 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-15 19:08 Perf lib sanity tests fail on OSX Sangeeta
2020-12-16  2:18 ` Philippe Blain
2020-12-16  7:44   ` Eric Sunshine
2020-12-22  5:23     ` Sangeeta [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAHjREB6y_zr-TrEsQu5MpwegpSHg_5XxWLf0O_HFRrSg+sFvQg@mail.gmail.com \
    --to=sangunb09@gmail.com \
    --cc=christian.couder@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=johannes.schindelin@gmx.de \
    --cc=kaartic.sivaraam@gmail.com \
    --cc=larsxschneider@gmail.com \
    --cc=levraiphilippeblain@gmail.com \
    --cc=sunshine@sunshineco.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).