From: Ramkumar Ramachandra <artagnon@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Git List <git@vger.kernel.org>, Jeff King <peff@peff.net>,
Eric Sunshine <sunshine@sunshineco.com>,
Jonathan Nieder <jrnieder@gmail.com>
Subject: Re: [PATCH 4/6] remote.c: introduce a way to have different remotes for fetch/push
Date: Thu, 21 Mar 2013 01:13:58 +0530 [thread overview]
Message-ID: <CALkWK0=29fu92A8_XQCmW86U2y-ktNAOy4qMmJAhyYHo8FgX1Q@mail.gmail.com> (raw)
In-Reply-To: <7vfvzpevwf.fsf@alter.siamese.dyndns.org>
Junio C Hamano wrote:
> Ramkumar Ramachandra <artagnon@gmail.com> writes:
>
>> if (name)
>> name_given = 1;
>> else {
>> - name = default_remote_name;
>> - name_given = explicit_default_remote_name;
>> + if (pushremote_name) {
>> + name = pushremote_name;
>> + name_given = 1;
>> + } else {
>> + name = default_remote_name;
>> + name_given = explicit_default_remote_name;
>> + }
>> }
>
> The code to read branch.$name.remote configuration flips
> explicit_default_remote_name to one when it is used to set the
> default_remote_name, and that controls the value of name_given in
> this codepath. At this point in the series, you do not have a
> corresponding branch.$name.pushremote, but your [6/6] does not seem
> to do the same.
>
> Why isn't it necessary to add explicit_default_pushremote_name and
> do the same here in patch [6/6]?
Sorry, I'm still trying to understand your comment. Okay, yes:
branch.$name.remote does flip explicit_default_remote_name, because we
need to know if the default remote name was explicitly given. Wait,
how is explicit_default_remote_name used to set default_remote_name?
Don't you mean name_given? It controls name_give, yes. At this point
I don't have .pushremote, yes: I'm setting up for [5/6] and [6/6]. My
[6/6] doesn't seem to do the "same"? The same thing as .remote? Are
you asking why .pushremote doesn't flip explicit_default_remote_name
like .remote does? Because .pushremote can only ever be specified
explicitly: otherwise, it falls back to the .remote logic.
Okay, next paragraph. Why isn't it necessary to add
explicit_default_pushremote_name? Like I said, .pushremote can only
ever be specified explicitly. There is no implicit fallback (like
"origin"): it just falls back to the .remote codepath, if not
explicitly specified. In other words, it's just a small override on
the .remote codepath.
next prev parent reply other threads:[~2013-03-20 19:44 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-20 12:44 [PATCH v2 0/6] Support triangular workflows Ramkumar Ramachandra
2013-03-20 12:44 ` [PATCH 1/6] remote.c: simplify a bit of code using git_config_string() Ramkumar Ramachandra
2013-03-20 18:07 ` Jonathan Nieder
2013-03-20 18:12 ` Ramkumar Ramachandra
2013-03-20 12:44 ` [PATCH 2/6] t5516 (fetch-push): update test description Ramkumar Ramachandra
2013-03-20 18:22 ` Jonathan Nieder
2013-03-20 18:33 ` Ramkumar Ramachandra
2013-03-20 18:35 ` Jonathan Nieder
2013-03-20 12:44 ` [PATCH 3/6] t5516 (fetch-push): introduce mk_test_with_name() Ramkumar Ramachandra
2013-03-20 18:28 ` Jonathan Nieder
2013-03-20 18:38 ` Ramkumar Ramachandra
2013-03-20 18:41 ` Jonathan Nieder
2013-03-20 18:58 ` Jeff King
2013-03-20 19:52 ` Junio C Hamano
2013-03-20 20:00 ` Jonathan Nieder
2013-03-20 12:44 ` [PATCH 4/6] remote.c: introduce a way to have different remotes for fetch/push Ramkumar Ramachandra
2013-03-20 18:30 ` Jonathan Nieder
2013-03-20 19:03 ` Junio C Hamano
2013-03-20 19:43 ` Ramkumar Ramachandra [this message]
2013-03-20 19:48 ` Junio C Hamano
2013-03-20 12:45 ` [PATCH 5/6] remote.c: introduce remote.pushdefault Ramkumar Ramachandra
2013-03-20 18:32 ` Jonathan Nieder
2013-03-20 18:53 ` Junio C Hamano
2013-03-20 19:46 ` Ramkumar Ramachandra
2013-03-20 12:45 ` [PATCH 6/6] remote.c: introduce branch.<name>.pushremote Ramkumar Ramachandra
2013-03-20 13:03 ` Tay Ray Chuan
2013-03-20 13:35 ` Ramkumar Ramachandra
2013-03-20 13:06 ` [PATCH v2 0/6] Support triangular workflows Tay Ray Chuan
2013-03-22 7:44 ` Ramkumar Ramachandra
2013-03-20 23:04 ` Philip Oakley
2013-03-22 7:41 ` Ramkumar Ramachandra
2013-03-22 15:16 ` Junio C Hamano
2013-03-23 12:42 ` Ramkumar Ramachandra
2013-03-22 7:52 [PATCH v3 " Ramkumar Ramachandra
2013-03-22 7:52 ` [PATCH 4/6] remote.c: introduce a way to have different remotes for fetch/push Ramkumar Ramachandra
2013-03-22 21:21 ` Jonathan Nieder
2013-03-22 22:13 ` Junio C Hamano
2013-03-22 23:41 ` Jonathan Nieder
2013-03-23 13:18 ` Ramkumar Ramachandra
2013-03-23 12:57 ` Ramkumar Ramachandra
2013-03-28 13:26 [PATCH v4 0/6] Support triangular workflows Ramkumar Ramachandra
2013-03-28 13:26 ` [PATCH 4/6] remote.c: introduce a way to have different remotes for fetch/push Ramkumar Ramachandra
2013-04-02 7:40 [PATCH 0/6] Re-roll rr/triangle Ramkumar Ramachandra
2013-04-02 7:40 ` [PATCH 4/6] remote.c: introduce a way to have different remotes for fetch/push Ramkumar Ramachandra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CALkWK0=29fu92A8_XQCmW86U2y-ktNAOy4qMmJAhyYHo8FgX1Q@mail.gmail.com' \
--to=artagnon@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jrnieder@gmail.com \
--cc=peff@peff.net \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).