From: Danny Lin <danny0838@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git develop <git@vger.kernel.org>
Subject: Re: [PATCH] Remove "unsure" for --message in subtree doc.
Date: Sat, 15 Aug 2020 10:31:43 +0800 [thread overview]
Message-ID: <CAMbsUu6WnHori2t1qG=6UVLWDNEw5FSXeTd-K6WKnpZi5h6q+w@mail.gmail.com> (raw)
In-Reply-To: <xmqqbljdxgkh.fsf@gitster.c.googlers.com>
Sorry, I missed that.
Further investigation suggests that it works with 'split --rejoin' and
has nothing to do with 'push' (actually, push never generates a merged
commit at all). We can rephrase for that.
Junio C Hamano <gitster@pobox.com> writes:
>
> Danny Lin <danny0838@gmail.com> writes:
>
> > It is definitely clear that --message is valid for add, merge and pull.
>
> If it is also definitely clear that it is _only_ valid for those
> three, then the change is good. I do not know if that is true
> offhand, though.
>
next prev parent reply other threads:[~2020-08-15 21:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-14 14:53 [PATCH] Remove "unsure" for --message in subtree doc Danny Lin
2020-08-14 17:50 ` Junio C Hamano
2020-08-15 2:31 ` Danny Lin [this message]
2020-08-15 2:32 ` [PATCH] Revise supported options " Danny Lin
2020-08-17 16:47 ` Junio C Hamano
2020-08-18 5:21 ` [PATCH] contrib/subtree: fix "unsure" for --message in the document Danny Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMbsUu6WnHori2t1qG=6UVLWDNEw5FSXeTd-K6WKnpZi5h6q+w@mail.gmail.com' \
--to=danny0838@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).