From: "Martin Ågren" <martin.agren@gmail.com> To: Felipe Contreras <felipe.contreras@gmail.com> Cc: Git Mailing List <git@vger.kernel.org>, Jeff King <peff@peff.net>, "brian m . carlson" <sandals@crustytoothpaste.net>, Junio C Hamano <gitster@pobox.com> Subject: Re: [PATCH 7/8] doc: improve asciidoc dependencies Date: Thu, 13 May 2021 19:43:26 +0200 [thread overview] Message-ID: <CAN0heSoWPUvc+kQO2oXx1XnpOp7=jesGJ80XZm6EjTe15RxQLQ@mail.gmail.com> (raw) In-Reply-To: <20210512222803.508446-8-felipe.contreras@gmail.com> On Thu, 13 May 2021 at 00:28, Felipe Contreras <felipe.contreras@gmail.com> wrote: > > asciidoc needs asciidoc.conf, asciidoctor asciidoctor-extensions.rb. > > Neither needs the other. > -ASCIIDOC_DEPS = asciidoc.conf asciidoctor-extensions.rb GIT-ASCIIDOCFLAGS > +ASCIIDOC_DEPS = asciidoc.conf GIT-ASCIIDOCFLAGS > +ASCIIDOC_DEPS = asciidoctor-extensions.rb GIT-ASCIIDOCFLAGS Thanks. I was a bit lazy in a15ef383e7 ("Documentation/Makefile: add missing dependency on asciidoctor-extensions", 2019-02-27). We end up with some duplication. We could pull GIT-ASCIIDOCFLAGS into some ASCIIDOC_DEPS_COMMON. But with just one such common dependency, it seems unnecessary and overly complicated. We can pull out the common dependencies when we actually gain something from it. Martin
next prev parent reply other threads:[~2021-05-13 17:43 UTC|newest] Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-05-12 22:27 [PATCH 0/8] doc: asciidoc cleanups Felipe Contreras 2021-05-12 22:27 ` [PATCH 1/8] doc: standardize asciidoc calls Felipe Contreras 2021-05-12 22:27 ` [PATCH 2/8] doc: add an asciidoc helper Felipe Contreras 2021-05-13 15:17 ` Ævar Arnfjörð Bjarmason 2021-05-13 19:33 ` Felipe Contreras 2021-05-13 21:43 ` Junio C Hamano 2021-05-12 22:27 ` [PATCH 3/8] doc: disable asciidoc-helper for asciidoctor Felipe Contreras 2021-05-12 22:27 ` [PATCH 4/8] doc: simplify the handling of interruptions Felipe Contreras 2021-05-13 5:19 ` Junio C Hamano 2021-05-13 6:10 ` Felipe Contreras 2021-05-12 22:28 ` [PATCH 5/8] doc: remove redundant rm Felipe Contreras 2021-05-13 15:22 ` Ævar Arnfjörð Bjarmason 2021-05-13 18:58 ` Felipe Contreras 2021-05-12 22:28 ` [PATCH 6/8] doc: refactor common dependencies Felipe Contreras 2021-05-12 22:28 ` [PATCH 7/8] doc: improve asciidoc dependencies Felipe Contreras 2021-05-13 17:43 ` Martin Ågren [this message] 2021-05-12 22:28 ` [PATCH 8/8] doc: join xml and man rules Felipe Contreras 2021-05-13 11:02 ` Martin Ågren 2021-05-13 11:15 ` Felipe Contreras
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CAN0heSoWPUvc+kQO2oXx1XnpOp7=jesGJ80XZm6EjTe15RxQLQ@mail.gmail.com' \ --to=martin.agren@gmail.com \ --cc=felipe.contreras@gmail.com \ --cc=git@vger.kernel.org \ --cc=gitster@pobox.com \ --cc=peff@peff.net \ --cc=sandals@crustytoothpaste.net \ --subject='Re: [PATCH 7/8] doc: improve asciidoc dependencies' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).