git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Martin Ågren" <martin.agren@gmail.com>
To: ZheNing Hu <adlternative@gmail.com>
Cc: Git List <git@vger.kernel.org>, Taylor Blau <me@ttaylorr.com>,
	Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH 2/2] pretty-formats.txt: add missing space
Date: Sun, 9 May 2021 17:27:55 +0200	[thread overview]
Message-ID: <CAN0heSqi9v3dGgGFSGB7J-17MJj9jOvMwC6x7pW1bRGwra5N2g@mail.gmail.com> (raw)
In-Reply-To: <CAOLTT8R2ACJtcL7esLd8AiSu22Wn2hrdVTwub-HXc-eT_U2-+w@mail.gmail.com>

On Sun, 9 May 2021 at 16:13, ZheNing Hu <adlternative@gmail.com> wrote:
>
> Martin Ågren <martin.agren@gmail.com> 于2021年5月9日周日 下午5:10写道：
> >
> > The description of "%ch" is missing a space after "human style", before
> > the parenthetical remark. This description was introduced in b722d4560e
> > ("pretty: provide human date format", 2021-04-25). That commit also
> > added "%ah", which does have the space already.

> > --- a/Documentation/pretty-formats.txt
> > +++ b/Documentation/pretty-formats.txt
> > @@ -208,7 +208,7 @@ The placeholders are:
> >  '%ci':: committer date, ISO 8601-like format
> >  '%cI':: committer date, strict ISO 8601 format
> >  '%cs':: committer date, short format (`YYYY-MM-DD`)
> > -'%ch':: committer date, human style(like the `--date=human` option of
> > +'%ch':: committer date, human style (like the `--date=human` option of
> >         linkgit:git-rev-list[1])

> Sorry, but in here:[1], I have fixed this space missing error.
>
> Junio, this patch have not been merged to master?
>
> [1]: https://lore.kernel.org/git/pull.939.v4.git.1620056221874.gitgitgadget@gmail.com/

Ah, thanks for the pointer. It looks like this was merged to "next" in
2320ad8fb0 ("Merge branch 'zh/pretty-date-human' into next", 2021-04-30), so a
few days before you sent v4.

Junio probably missed v4 entirely, or he might have responded with something
like "v3 is already in next, so please build incrementally on top of it".

Thanks for contributing this functionality. I quite like the "human" format.

Martin

  reply	other threads:[~2021-05-09 15:28 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-09  9:09 [PATCH 0/2] minor doc fixes Martin Ågren
2021-05-09  9:09 ` [PATCH 1/2] git-repack.txt: remove spurious ")" Martin Ågren
2021-05-09  9:10 ` [PATCH 2/2] pretty-formats.txt: add missing space Martin Ågren
2021-05-09 14:13   ` ZheNing Hu
2021-05-09 15:27     ` Martin Ågren [this message]
2021-05-10  4:14       ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAN0heSqi9v3dGgGFSGB7J-17MJj9jOvMwC6x7pW1bRGwra5N2g@mail.gmail.com \
    --to=martin.agren@gmail.com \
    --cc=adlternative@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=me@ttaylorr.com \
    --subject='Re: [PATCH 2/2] pretty-formats.txt: add missing space' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).