From: "Martin Ågren" <firstname.lastname@example.org>
To: Felipe Contreras <email@example.com>
Cc: Junio C Hamano <firstname.lastname@example.org>,
Bagas Sanjaya <email@example.com>,
Git Mailing List <firstname.lastname@example.org>,
"brian m . carlson" <email@example.com>,
Jeff King <firstname.lastname@example.org>
Subject: Re: [PATCH] INSTALL: note about make man with Asciidoctor backend
Date: Thu, 13 May 2021 15:41:11 +0200 [thread overview]
Message-ID: <CAN0heSrNzxSpq=trPvOHAYx_yT1W=WuN1XstzTRjHdZko-i+DA@mail.gmail.com> (raw)
On Wed, 12 May 2021 at 10:13, Felipe Contreras
> Junio C Hamano wrote:
> > Bagas Sanjaya <email@example.com> writes:
> > > + You can also do "make man" using Asciidoctor's manpage backend in
> > > + place of xmlto by passing USE_ASCIIDOCTOR_MANPAGE=YesPlease. Version
> > > + 2.0 or later is highly recommended, as these version properly handle
> > > + apostrophes.
> > > +
> > Hmph, I wasn't closely following the previous discussion, but is the
> > apostrophes the primary reason why anything below 2.0 is not usable?
> "Not usable"?
> I haven't been able to reproduce the original supposed problem, but even
> if true, the man pages would be quite usable.
Even early 2.0.x had some issues . It's always debatable whether they're
significant or not, i.e., is a significant speed-up worth it if the
result is just-as-informative-but-a-bit-ugly-here-and-there? We should
provide some rough background here to help people and distros decide.
Maybe something like
"This can be quite a bit faster and requires fewer dependencies, but
please note that this is early work: there are some typographical
issues we know of, and there might be others."
but hopefully phrased better than that. I would suggest the commit
message saying something like "I skimmed through the doc-diff between
the asciidoctor-with-xmlto and asciidoctor-without-xmlto (using
asciidoctor v2.x.y) -- there are quite many minor differences, but
nothing particularly jarring stands out".
next prev parent reply other threads:[~2021-05-13 13:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-12 6:41 Bagas Sanjaya
2021-05-12 7:00 ` Junio C Hamano
2021-05-12 8:13 ` Felipe Contreras
2021-05-13 13:41 ` Martin Ågren [this message]
2021-05-13 20:23 ` Junio C Hamano
2021-06-02 20:07 ` Felipe Contreras
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--subject='Re: [PATCH] INSTALL: note about make man with Asciidoctor backend' \
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).