git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Miriam R." <mirucam@gmail.com>
To: Christian Couder <christian.couder@gmail.com>, git <git@vger.kernel.org>
Subject: Re: [Outreachy][PATCH] abspath: reconcile `dir_exists()` and `is_directory()`
Date: Sat, 26 Oct 2019 20:42:34 +0200	[thread overview]
Message-ID: <CAN7CjDCS3MNgdFd8NBkNEt3E+hfNgWiKizpEkQ1xjPbEkNrC3g@mail.gmail.com> (raw)
In-Reply-To: <CAP8UFD3pOL27VEO_42mXP_mfM689hRWLBU3KR0zJLgQKrX9ZPA@mail.gmail.com>

El sáb., 26 oct. 2019 a las 20:05, Christian Couder
(<christian.couder@gmail.com>) escribió:
>
> Hi Miriam,
>
> On Sat, Oct 26, 2019 at 5:31 PM Miriam R. <mirucam@gmail.com> wrote:
> >
> > Dear all,
> > there is already a static function called path_exists() in archive.c
> > so project does not compile.
> >
> > Maybe we could change the name of this static function and its
> > reference in archive.c like archive_path_exists() for example, or some
> > other you find more suitable.
>
> Yeah, I think renaming the function archive_path_exists() in a
> preparatory patch would be a good way to move forward on this.
>
> Best,
> Christian.

Great!
Thank you, Christian.

      reply	other threads:[~2019-10-26 18:42 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-24  9:27 [Outreachy][PATCH] abspath: reconcile `dir_exists()` and `is_directory()` Miriam Rubio
2019-10-24 11:41 ` SZEDER Gábor
2019-10-24 18:13   ` Jeff King
2019-10-24 20:45     ` Emily Shaffer
2019-10-24 20:51       ` Jeff King
2019-10-25  2:40         ` Junio C Hamano
2019-10-24 20:57   ` Miriam R.
2019-10-25  2:45   ` Junio C Hamano
2019-10-25  8:59     ` Miriam R.
2019-10-25  9:43       ` Junio C Hamano
2019-10-25 14:47         ` Christian Couder
2019-10-25 15:23           ` Miriam R.
2019-10-26 15:30             ` Miriam R.
2019-10-26 18:05               ` Christian Couder
2019-10-26 18:42                 ` Miriam R. [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAN7CjDCS3MNgdFd8NBkNEt3E+hfNgWiKizpEkQ1xjPbEkNrC3g@mail.gmail.com \
    --to=mirucam@gmail.com \
    --cc=christian.couder@gmail.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).