git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Arun Sharma <arun@sharma-home.net>
To: git@vger.kernel.org
Subject: bug report: mutual recursion in the git-subtree shell script
Date: Sat, 13 Mar 2021 08:06:18 -0800	[thread overview]
Message-ID: <CAN7rbOve-EFOGPjr1wrD77r-3RQ+3+qso82_oV5Qud-skobL7w@mail.gmail.com> (raw)

[ resending bug report from git-users since there weren't any responses ]

So I'm trying to split out a directory from postgres source code
(which has 52k commits). I was able to split a directory into a
separate subtree (with 1685 commits). All good so far.

Now I do a pull from upstream and want to push the directory to my
subtree. The command fails with:

$ git subtree push --prefix=src/interfaces/libpq libpq master
/usr/lib/git-core/git-subtree: 647: Maximum function recursion depth
(1000) reached

As far as I can see, it seems to be a mutual recursion between

process_split_commit() and check_parents()

If this diagnosis is correct, are there any known workarounds? I've
tried increasing ulimit -s and FUNCNEST=10000, but it didn't fix the
problem.

Can this flow be coded without using recursion? Are there
implementations of git-subtree in another language which doesn't have
this problem?

 -Arun

             reply	other threads:[~2021-03-13 16:07 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-13 16:06 Arun Sharma [this message]
2021-03-13 17:02 ` bug report: mutual recursion in the git-subtree shell script brian m. carlson
2021-03-14 17:31   ` Arun Sharma
2021-03-15  5:19     ` Johannes Schindelin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAN7rbOve-EFOGPjr1wrD77r-3RQ+3+qso82_oV5Qud-skobL7w@mail.gmail.com \
    --to=arun@sharma-home.net \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).