git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jayati Shrivastava <gaurijove@gmail.com>
To: Christian Couder <christian.couder@gmail.com>
Cc: Hariom verma <hariom18599@gmail.com>, git <git@vger.kernel.org>
Subject: Re: [GSOC] [PATCH 1/1] t7403: Use helper function 'test_path_is_dir' to check if the path is a directory
Date: Tue, 15 Mar 2022 21:41:36 +0530	[thread overview]
Message-ID: <CANsrJQd-E9JcFD0jtK=kMexm0Oc4Vc2HSXJ7nM2u3g4cN0zstA@mail.gmail.com> (raw)
In-Reply-To: <CAP8UFD0GeGr3ARkYycHNYU0r5vTC-PDdbLYrkYSohbtWBt9HSQ@mail.gmail.com>

Hi Christian,

Thanks for reviewing.

>On Tue, Mar 15, 2022 at 2:20 PM Christian Couder <christian.couder@gmail.com> wrote:

> Thanks for this patch! I am curious what tool you used to prepare and
> send it.This is not a big deal but when there is only one patch I
> think [PATCH] is preferred over [PATCH 1/1]. Also I think the 'From:
> JAYATI...' line is not nécessary if you are sending the patch using
> the same email address as what's in the 'From: JAYATI...' line.

I am using git format-patch and send-email but had previously made
some unnecessary modifications in the editor which I have now done
away with.

> It's nice to say why it's better to use functions like
> test_path_is_dir() rather than `test -d`. Also it looks like the last
> line could be formatted to be around the same length as previous
> lines, instead of being significantly longer.
> The sentence should end with a full stop.
>
> > Signed-off-by: JAYATI SHRIVASTAVA <gaurijove@gmail.com>
>
> It's also not a big deal, but, unless it's really a personal
> preference, you might not want to use only uppercase letters for your
> name, as it's not usual here.

I have modified the commit message as per your reviews. However,
I am not sure why my patches are still not showing up on the mailing
list despite passing the --to/--cc/--in-reply-to options correctly to
git send-email. What do you think might be the reason?

  reply	other threads:[~2022-03-15 16:11 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20220313105031.1081110-1-gaurijove@gmail.com>
2022-03-15  8:50 ` [GSOC] [PATCH 1/1] t7403: Use helper function 'test_path_is_dir' to check if the path is a directory Christian Couder
2022-03-15 16:11   ` Jayati Shrivastava [this message]
2022-03-15 20:00     ` Christian Couder

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CANsrJQd-E9JcFD0jtK=kMexm0Oc4Vc2HSXJ7nM2u3g4cN0zstA@mail.gmail.com' \
    --to=gaurijove@gmail.com \
    --cc=christian.couder@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=hariom18599@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).