git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Bo Zhang <zhangbodut@gmail.com>
To: Jeff King <peff@peff.net>
Cc: git@vger.kernel.org
Subject: Re: Potential asterisk expansion bug in Windows Git Bash?
Date: Wed, 14 Aug 2019 20:38:18 +0800	[thread overview]
Message-ID: <CAO=KXnvrVdTRW=FhKMixSHuR-qahJ2QqUKOn4PerZAVcxVJHww@mail.gmail.com> (raw)
In-Reply-To: <20190814121045.GA30302@sigill.intra.peff.net>

Thank you very much Jeff!

It turns out I ran into
https://bugs.openjdk.java.net/browse/JDK-8131329 on Windows. The
example was also a mistake. Anyway, false alarm, thank you again!

Regards,
Bo

On Wed, Aug 14, 2019 at 8:10 PM Jeff King <peff@peff.net> wrote:
>
> On Wed, Aug 14, 2019 at 07:50:47PM +0800, Bo Zhang wrote:
>
> > Today I noticed that on Windows Git Bash, the asterisk (*) is
> > incorrectly expanded even when it’s in a quote or following a
> > backslash (\). I’m wondering if this is the correct behaviour (which
> > seems like to me NOT).
> >
> > Step to reproduce (in Windows git bash):
> >
> > zhb@zhb-PC MINGW64 ~/Desktop
> > $ bash --version
> > GNU bash, version 4.4.19(2)-release (x86_64-pc-msys)
> > Copyright (C) 2016 Free Software Foundation, Inc.
> > License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html>
> >
> > This is free software; you are free to change and redistribute it.
> > There is NO WARRANTY, to the extent permitted by law.
> >
> > zhb@zhb-PC MINGW64 ~/Desktop
> > $ cat 1.sh
> > echo $1
>
> Your script doesn't quote "$1", so whatever you pass in will be subject
> to wildcard expansion inside the shell running the script.
>
> Try this:
>
>   $ cat bad.sh
>   echo $1
>   $ cat good.sh
>   echo "$1"
>
>   $ bash bad.sh '*'
>   bad.sh good.sh
>
>   $ bash good.sh '*'
>   *
>
> > zhb@zhb-PC MINGW64 ~/Desktop
> > $ bash 1.sh '*'
> > $A 1.sh 1.txt
>
> So this is the case I showed above.
>
> > zhb@zhb-PC MINGW64 ~/Desktop
> > $ bash 1.sh "*"
> > $A 1.sh 1.txt
>
> And this is equivalent. The quotes suppress wildcard expansion in your
> interactive shell, but the script itself does another round of
> expansion.
>
> > zhb@zhb-PC MINGW64 ~/Desktop
> > $ bash 1.sh \*
> > 1.sh 1.txt
>
> And same here.
>
> -Peff

      reply	other threads:[~2019-08-14 12:38 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-14 11:50 Potential asterisk expansion bug in Windows Git Bash? Bo Zhang
2019-08-14 12:10 ` Jeff King
2019-08-14 12:38   ` Bo Zhang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAO=KXnvrVdTRW=FhKMixSHuR-qahJ2QqUKOn4PerZAVcxVJHww@mail.gmail.com' \
    --to=zhangbodut@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).