From: ZheNing Hu <adlternative@gmail.com>
To: Phillip Wood <phillip.wood123@gmail.com>
Cc: Felipe Contreras <felipe.contreras@gmail.com>,
ZheNing Hu via GitGitGadget <gitgitgadget@gmail.com>,
Git List <git@vger.kernel.org>,
Junio C Hamano <gitster@pobox.com>,
Christian Couder <christian.couder@gmail.com>,
Hariom Verma <hariom18599@gmail.com>,
Karthik Nayak <karthik.188@gmail.com>,
Bagas Sanjaya <bagasdotme@gmail.com>, Jeff King <peff@peff.net>
Subject: Re: [PATCH 1/2] [GSOC] ref-filter: add %(raw) atom
Date: Sun, 30 May 2021 14:26:20 +0800 [thread overview]
Message-ID: <CAOLTT8QmByyue25YLTa2-=oQ00K5Cs_eoSD3_y6wRYYToa=oxQ@mail.gmail.com> (raw)
In-Reply-To: <13c63e79-27fd-58d5-9a4c-6b58c40ef4b8@gmail.com>
Phillip Wood <phillip.wood123@gmail.com> 于2021年5月29日周六 下午9:23写道:
>
> On 27/05/2021 17:36, Felipe Contreras wrote:
> > ZheNing Hu via GitGitGadget wrote:
> > [...]
> >> +static int memcasecmp(const void *vs1, const void *vs2, size_t n)
> >
> > Why void *? We can delcare as char *.
>
> If you look at how this function is used you'll see
> int (*cmp_fn)(const void *, const void *, size_t);
> cmp_fn = s->sort_flags & REF_SORTING_ICASE
> ? memcasecmp : memcmp;
>
> So the signature must match memcmp to avoid undefined behavior (a
> ternary expression is undefined unless both sides evaluate to the same
> type and calling a function through a pointer a different type is
> undefined as well)
>
I agree.
> >> +{
> >> + size_t i;
> >> + const char *s1 = (const char *)vs1;
> >> + const char *s2 = (const char *)vs2;
> >
> > Then we avoid this extra step.
> >
> >> + for (i = 0; i < n; i++) {
> >> + unsigned char u1 = s1[i];
> >> + unsigned char u2 = s2[i];
> >
> > There's no need for two entirely new variables...
> >
> >> + int U1 = toupper (u1);
> >> + int U2 = toupper (u2);
> >
> > You can do toupper(s1[i]) directly (BTW, there's an extra space: `foo(x)`,
> > not `foo (x)`).
> >
> > While we are at it, why keep an extra index from s1, when s1 is never
> > used again?
> >
> > We can simply advance both s1 and s2:
> >
> > s1++, s2++
> >
> >> + int diff = (UCHAR_MAX <= INT_MAX ? U1 - U2
> >> + : U1 < U2 ? -1 : U2 < U1);
> >
> > I don't understand what this is supposed to achieve. Both U1 and U2 are
> > integers, pretty low integers actually.
> >
> > If we get rid if that complexity we don't even need U1 or U2, just do:
> >
> > diff = toupper(u1) - toupper(u2);
> >
> >> + if (diff)
> >> + return diff;
> >> + }
> >> + return 0;
> >> +}
> >
> > All we have to do is define the end point, and then we don't need i:
> >
> > static int memcasecmp(const char *s1, const char *s2, size_t n)
> > {
> > const char *end = s1 + n;
> > for (; s1 < end; s1++, s2++) {
> > int diff = tolower(*s1) - tolower(*s2);
> > if (diff)
> > return diff;
> > }
> > return 0;
> > }
> >
> > (and I personally prefer lower to upper)
>
> We should be using tolower() as that is what POSIX specifies for
> strcasecmp() [1] which we are trying to emulate and there are cases[2] where
> (tolower(c1) == tolower(c2)) != (toupper(c1) == toupper(c2))
>
I don’t know if we overlooked a fact: This static `memcasecmp()`
is not a POSIX version. `tolower()` or `toupper()` are in git-compat-util.h,
sane_istest('\0', GIT_ALPHA) == false . So in `sane_case()`, whatever
`tolower()`, `toupper()`, they just return '\0' itself.
> Best Wishes
>
> Phillip
>
> [1] https://pubs.opengroup.org/onlinepubs/9699919799/
> [2] https://en.wikipedia.org/wiki/Dotted_and_dotless_I#In_computing
>
Thanks.
--
ZhenNing Hu
next prev parent reply other threads:[~2021-05-30 6:26 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-27 14:43 [PATCH 0/2] [GSOC] ref-filter: add %(raw) atom ZheNing Hu via GitGitGadget
2021-05-27 14:43 ` [PATCH 1/2] " ZheNing Hu via GitGitGadget
2021-05-27 16:36 ` Felipe Contreras
2021-05-28 13:02 ` ZheNing Hu
2021-05-28 16:30 ` Felipe Contreras
2021-05-30 5:37 ` ZheNing Hu
2021-05-29 13:23 ` Phillip Wood
2021-05-29 15:24 ` Felipe Contreras
2021-05-29 17:23 ` Phillip Wood
2021-05-30 6:29 ` ZheNing Hu
2021-05-30 13:05 ` Phillip Wood
2021-05-31 14:15 ` ZheNing Hu
2021-05-31 15:35 ` Felipe Contreras
2021-05-30 6:26 ` ZheNing Hu [this message]
2021-05-30 13:02 ` Phillip Wood
2021-05-28 3:03 ` Junio C Hamano
2021-05-28 15:04 ` ZheNing Hu
2021-05-28 16:38 ` Felipe Contreras
2021-05-30 8:11 ` ZheNing Hu
2021-05-27 14:43 ` [PATCH 2/2] [GSOC] ref-filter: add %(header) atom ZheNing Hu via GitGitGadget
2021-05-27 16:37 ` Felipe Contreras
2021-05-28 3:06 ` Junio C Hamano
2021-05-28 4:36 ` Junio C Hamano
2021-05-28 15:19 ` ZheNing Hu
2021-05-27 15:39 ` [PATCH 0/2] [GSOC] ref-filter: add %(raw) atom Felipe Contreras
2021-05-30 13:01 ` [PATCH v2 " ZheNing Hu via GitGitGadget
2021-05-30 13:01 ` [PATCH v2 1/2] [GSOC] ref-filter: add obj-type check in grab contents ZheNing Hu via GitGitGadget
2021-05-31 5:34 ` Junio C Hamano
2021-05-30 13:01 ` [PATCH v2 2/2] [GSOC] ref-filter: add %(raw) atom ZheNing Hu via GitGitGadget
2021-05-31 0:44 ` Junio C Hamano
2021-05-31 14:35 ` ZheNing Hu
2021-06-01 9:54 ` Junio C Hamano
2021-06-01 11:05 ` ZheNing Hu
2021-05-31 4:04 ` Junio C Hamano
2021-05-31 14:40 ` ZheNing Hu
2021-06-01 8:54 ` Junio C Hamano
2021-06-01 11:00 ` ZheNing Hu
2021-06-01 13:48 ` Johannes Schindelin
2021-05-31 4:10 ` Junio C Hamano
2021-05-31 15:41 ` Felipe Contreras
2021-06-01 10:37 ` ZheNing Hu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAOLTT8QmByyue25YLTa2-=oQ00K5Cs_eoSD3_y6wRYYToa=oxQ@mail.gmail.com' \
--to=adlternative@gmail.com \
--cc=bagasdotme@gmail.com \
--cc=christian.couder@gmail.com \
--cc=felipe.contreras@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=gitster@pobox.com \
--cc=hariom18599@gmail.com \
--cc=karthik.188@gmail.com \
--cc=peff@peff.net \
--cc=phillip.wood123@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).