From: ZheNing Hu <adlternative@gmail.com> To: Jeff King <peff@peff.net> Cc: Git List <git@vger.kernel.org> Subject: Re: [PATCH 1/2] ref-filter: hacky "streaming" mode Date: Wed, 15 Sep 2021 22:23:43 +0800 [thread overview] Message-ID: <CAOLTT8SYxUbfG7YvAs03nwRdee8JfNPUYCCpKcFoAgBjB2oqLw@mail.gmail.com> (raw) In-Reply-To: <CAOLTT8RPzutEQxbr9cu=ze7rgPKvG6Ghu4b2Bi47eStY1TqGzQ@mail.gmail.com> ZheNing Hu <adlternative@gmail.com> 于2021年9月15日周三 下午8:27写道: > > > So yes, it's complicated. And it must be explained to the user that > > "%(refname)" behaves slightly differently with "git tag --verify", but > > that is unavoidable if we do not want to break scripts (it _already_ > > behaves slightly differently, and we just never told anyone). > > $ git tag --verify --format='verify: %(refname) %(symref)' annotated symref verify: annotated verify: symref $ git tag --verify --format='verify: %(refname) %(symref)' refs/tags/annotated refs/tags/symref error: tag 'refs/tags/annotated' not found. error: tag 'refs/tags/symref' not found. $ git verify-tag --format='verify: %(refname) %(symref)' annotated symref verify: annotated verify: symref $ git verify-tag --format='verify: %(refname) %(symref)' refs/tags/annotated refs/tags/symref verify: refs/tags/annotated verify: refs/tags/symref As we can see, there is a slight difference between git tag --verify and git verify-tag: git tag --verify can not handle refs' fullname refs/tags/* (because read_ref_full() | read_ref() can't handle them). So, as a standard, which characteristics should we keep? > > The other option is to declare the current behavior a bug and fix it. I > > am quite tempted by that route, given the inconsistency with other > > formatters, including even "git tag --list --format=%(refname)"! > > I don't know, I think both fix methods are okay. > > > > > -Peff > > Thanks. > -- > ZheNing Hu
next prev parent reply other threads:[~2021-09-15 14:23 UTC|newest] Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-09-04 12:40 [hacky PATCH 0/2] speeding up trivial for-each-ref invocations Jeff King 2021-09-04 12:41 ` [PATCH 1/2] ref-filter: hacky "streaming" mode Jeff King 2021-09-05 8:20 ` ZheNing Hu 2021-09-05 13:04 ` Jeff King 2021-09-07 5:28 ` ZheNing Hu 2021-09-07 18:01 ` Jeff King 2021-09-09 14:45 ` ZheNing Hu 2021-09-10 14:26 ` Jeff King 2021-09-15 12:27 ` ZheNing Hu 2021-09-15 14:23 ` ZheNing Hu [this message] 2021-09-16 21:45 ` Jeff King 2021-09-20 7:42 ` ZheNing Hu 2021-09-16 21:31 ` Jeff King 2021-09-05 13:15 ` Jeff King 2021-09-07 5:42 ` ZheNing Hu 2021-09-04 12:42 ` [PATCH 2/2] ref-filter: implement "quick" formats Jeff King 2021-09-05 8:20 ` ZheNing Hu 2021-09-05 13:07 ` Jeff King 2021-09-06 13:34 ` ZheNing Hu 2021-09-07 20:06 ` Junio C Hamano 2021-09-05 8:19 ` [hacky PATCH 0/2] speeding up trivial for-each-ref invocations ZheNing Hu 2021-09-05 12:49 ` Jeff King 2021-09-06 13:30 ` ZheNing Hu 2021-09-07 17:28 ` Jeff King 2021-09-09 13:20 ` ZheNing Hu 2021-09-06 6:54 ` Patrick Steinhardt
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=CAOLTT8SYxUbfG7YvAs03nwRdee8JfNPUYCCpKcFoAgBjB2oqLw@mail.gmail.com \ --to=adlternative@gmail.com \ --cc=git@vger.kernel.org \ --cc=peff@peff.net \ --subject='Re: [PATCH 1/2] ref-filter: hacky "streaming" mode' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).