From: ZheNing Hu <adlternative@gmail.com>
To: Christian Couder <christian.couder@gmail.com>
Cc: Junio C Hamano <gitster@pobox.com>,
Hariom verma <hariom18599@gmail.com>,
Git List <git@vger.kernel.org>
Subject: Re: [GSoC] Git Blog 11
Date: Tue, 3 Aug 2021 10:37:06 +0800 [thread overview]
Message-ID: <CAOLTT8SaXqWF3AJssqudrDK-KZN3oESO7Xh0JTYB_=HR9L9sHg@mail.gmail.com> (raw)
In-Reply-To: <CAP8UFD16pqERdF4Mdq=_ktvFB1rcXwB9PRy8TjNq=ThH5HbeqA@mail.gmail.com>
Christian Couder <christian.couder@gmail.com> 于2021年8月2日周一 下午2:25写道:
>
> On Sun, Aug 1, 2021 at 8:45 AM ZheNing Hu <adlternative@gmail.com> wrote:
>
> > in some cases, this is the result of the performance test of
> > `t/perf/p1006-cat-file.sh`:
> >
> > ```
> > Test HEAD~ HEAD
> > ------------------------------------------------------------------------------------
> > 1006.2: cat-file --batch-check 0.10(0.09+0.00)
> > 0.11(0.10+0.00) +10.0%
> > 1006.3: cat-file --batch-check with atoms 0.09(0.08+0.01)
> > 0.09(0.06+0.03) +0.0%
> > 1006.4: cat-file --batch 0.62(0.58+0.04)
> > 0.57(0.54+0.03) -8.1%
> > 1006.5: cat-file --batch with atoms 0.63(0.60+0.02)
> > 0.52(0.49+0.02) -17.5%
> > ```
> >
> > We can see that the performance of `git cat-file --batch` has been a
> > certain improvement!
>
> Yeah, sure -8.1% or -17.5% is really nice! But why +10.0% for
> `cat-file --batch-check`?
>
I think it's not very important. Because our optimization is skipping
parse_object_buffer(), git cat-file --batch-check will not set oi->contentp
by default, parse_object_buffer() will not be executed, Therefore, we did
not optimize `git cat-file --batch-check` at all. 10% may be small enough
for git cat-file --batch-check. The noise of environment even will cover it...
> > Tell a joke: removing 1984531500 if checking can reduce the startup
> > time of GTA5 by 70%. :-D
>
> s/if checking/checks/
>
> As this joke refers to:
>
> https://rockstarintel.com/a-fan-reduces-gta-online-loading-times-by-70
>
> it might be nice to add a link to help people like me who didn't know
> about this and had to google it.
>
Ehhh, makes sense.
> > Currently the patch has not been submitted to the mailing list, let us
> > wait a bit...
>
> Looking forward to it...
I am afraid we need to wait until ref-filter-raw-data merged into master.
The preview version is here:
https://github.com/adlternative/git/commit/6fcf51c4b1cbb510dac775a6fbf3db361bc1c327
Thanks.
--
ZheNing Hu
next prev parent reply other threads:[~2021-08-03 2:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-01 6:46 [GSoC] Git Blog 11 ZheNing Hu
2021-08-02 6:25 ` Christian Couder
2021-08-03 2:37 ` ZheNing Hu [this message]
2021-08-03 2:49 ` ZheNing Hu
2021-08-04 8:56 ` Christian Couder
2021-08-05 4:50 ` ZheNing Hu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAOLTT8SaXqWF3AJssqudrDK-KZN3oESO7Xh0JTYB_=HR9L9sHg@mail.gmail.com' \
--to=adlternative@gmail.com \
--cc=christian.couder@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=hariom18599@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).