From: ZheNing Hu <adlternative@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: "Christian Couder" <christian.couder@gmail.com>,
"ZheNing Hu via GitGitGadget" <gitgitgadget@gmail.com>,
git <git@vger.kernel.org>,
"Bradley M. Kuhn" <bkuhn@sfconservancy.org>,
"Brandon Casey" <drafnel@gmail.com>,
"Shourya Shukla" <periperidip@gmail.com>,
"Rafael Silva" <rafaeloliveira.cs@gmail.com>,
"Đoàn Trần Công Danh" <congdanhqx@gmail.com>,
"Jeff King" <peff@peff.net>,
"Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Subject: Re: [PATCH v2 2/2] [GSOC] interpret-trailer: easy parse trailer value
Date: Mon, 22 Mar 2021 08:39:08 +0800 [thread overview]
Message-ID: <CAOLTT8TU+XwLmDQRROHW6iumFgMKok9mi+_OBmN4FbvgWkNb7Q@mail.gmail.com> (raw)
In-Reply-To: <xmqqwnu0bga9.fsf@gitster.g>
Junio C Hamano <gitster@pobox.com> 于2021年3月22日周一 上午12:52写道：
>
> Christian Couder <christian.couder@gmail.com> writes:
>
> >> "Signed-off-by:C O <Mister@email.com>" is often too
> >> verbose and error-prone.
> >
> > The 'trailer.<token>.command' config option can already be used to
> > help with that, for example:
> >
> > -------
> > $ git config trailer.sign.key "Signed-off-by: "
> > $ git config trailer.sign.ifexists replace
> > $ git config trailer.sign.command "git log --author='\$ARG' -1
> > --format='format:%aN <%aE>'"
> > $ git interpret-trailers --trailer sign=Linus<<EOF
> > subject
> >
> > body
> > EOF
> > subject
> >
> > body
> >
> > Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
> > -------
> >
> > So even without this patch, after your first patch that implements
> > `git commit --trailer ...`, it should be easy to setup something less
> > verbose and less error-prone.
>
> It is nice that it makes the complexity of 2/2 unnecessary ;-)
A little frustrated, both `--own-identity` and `@nickname` seem to be
rejected. I will roll back to the first patch.
next prev parent reply other threads:[~2021-03-22 0:40 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-20 14:41 [PATCH 0/2] [GSOC] interpret-trailer: easy parse trailer value ZheNing Hu via GitGitGadget
2021-03-20 14:41 ` [PATCH 1/2] [GSOC] commit: add --trailer option ZheNing Hu via GitGitGadget
2021-03-20 14:41 ` [PATCH 2/2] [GSOC] interpret-trailer: easy parse trailer value ZheNing Hu via GitGitGadget
2021-03-20 21:06 ` Junio C Hamano
2021-03-21 3:29 ` ZheNing Hu
2021-03-21 13:57 ` Junio C Hamano
2021-03-21 14:12 ` ZheNing Hu
2021-03-21 8:58 ` [PATCH v2 0/2] " ZheNing Hu via GitGitGadget
2021-03-21 8:58 ` [PATCH v2 1/2] [GSOC] commit: add --trailer option ZheNing Hu via GitGitGadget
2021-03-21 8:58 ` [PATCH v2 2/2] [GSOC] interpret-trailer: easy parse trailer value ZheNing Hu via GitGitGadget
2021-03-21 9:17 ` Bagas Sanjaya
2021-03-21 14:04 ` ZheNing Hu
2021-03-21 16:49 ` Junio C Hamano
2021-03-22 6:01 ` Bagas Sanjaya
2021-03-22 18:45 ` Junio C Hamano
2021-03-21 13:15 ` Christian Couder
2021-03-21 13:49 ` ZheNing Hu
2021-03-21 16:52 ` Junio C Hamano
2021-03-22 0:39 ` ZheNing Hu [this message]
2021-03-22 7:26 ` Christian Couder
2021-03-22 8:28 ` ZheNing Hu
2021-03-22 17:07 ` Junio C Hamano
2021-03-23 5:04 ` ZheNing Hu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAOLTT8TU+XwLmDQRROHW6iumFgMKok9mi+_OBmN4FbvgWkNb7Q@mail.gmail.com \
--to=adlternative@gmail.com \
--cc=avarab@gmail.com \
--cc=bkuhn@sfconservancy.org \
--cc=christian.couder@gmail.com \
--cc=congdanhqx@gmail.com \
--cc=drafnel@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
--cc=periperidip@gmail.com \
--cc=rafaeloliveira.cs@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).