From: Karthik Nayak <karthik.188@gmail.com>
To: Matthieu Moy <Matthieu.Moy@grenoble-inp.fr>
Cc: Git <git@vger.kernel.org>,
Christian Couder <christian.couder@gmail.com>,
Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH v2 3/8] branch: roll show_detached HEAD into regular ref_list
Date: Wed, 19 Aug 2015 21:27:25 +0530 [thread overview]
Message-ID: <CAOLa=ZTsgG4_hVV7+gEBt8AXWkYWi6AoB3Kj9wTYJ4KK60vE_g@mail.gmail.com> (raw)
In-Reply-To: <vpqpp2j2toq.fsf@anie.imag.fr>
On Wed, Aug 19, 2015 at 8:48 PM, Matthieu Moy
<Matthieu.Moy@grenoble-inp.fr> wrote:
> Karthik Nayak <karthik.188@gmail.com> writes:
>
>> + /*
>> + * First we obtain all regular branch refs and if the HEAD is
>> + * detached then we insert that ref to the end of the ref_fist
>> + * so that it can be printed first.
>> + */
>
> Nit: the end of the sentence reads funny (why put at the end "so that it
> can be printed first.").
>
> Perhaps "... so that it can be printed and removed first.".
>
Will change, thanks :)
--
Regards,
Karthik Nayak
next prev parent reply other threads:[~2015-08-19 15:58 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-18 19:15 [PATCH v2 0/8] port brnach.c to use ref-filter APIs Karthik Nayak
2015-08-18 19:15 ` [PATCH v2 1/8] branch: refactor width computation Karthik Nayak
2015-08-18 19:15 ` [PATCH v2 2/8] branch: bump get_head_description() to the top Karthik Nayak
2015-08-18 19:15 ` [PATCH v2 3/8] branch: roll show_detached HEAD into regular ref_list Karthik Nayak
2015-08-19 15:18 ` Matthieu Moy
2015-08-19 15:57 ` Karthik Nayak [this message]
2015-08-18 19:15 ` [PATCH v2 4/8] branch: move 'current' check down to the presentation layer Karthik Nayak
2015-08-18 19:15 ` [PATCH v2 5/8] branch: drop non-commit error reporting Karthik Nayak
2015-08-19 15:23 ` Matthieu Moy
2015-08-19 15:55 ` Karthik Nayak
2015-08-18 19:15 ` [PATCH v2 6/8] branch.c: use 'ref-filter' data structures Karthik Nayak
2015-08-18 19:15 ` [PATCH v2 7/8] branch.c: use 'ref-filter' APIs Karthik Nayak
2015-08-18 19:15 ` [PATCH v2 8/8] branch: add '--points-at' option Karthik Nayak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAOLa=ZTsgG4_hVV7+gEBt8AXWkYWi6AoB3Kj9wTYJ4KK60vE_g@mail.gmail.com' \
--to=karthik.188@gmail.com \
--cc=Matthieu.Moy@grenoble-inp.fr \
--cc=christian.couder@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).