From: Christian Couder <email@example.com> To: Matheus Tavares <firstname.lastname@example.org> Cc: "Junio C Hamano" <email@example.com>, git <firstname.lastname@example.org>, "Ævar Arnfjörð Bjarmason" <email@example.com> Subject: Re: [PATCH] t2080: fix cp invocation to copy symlinks instead of following them Date: Thu, 27 May 2021 09:25:49 +0200 [thread overview] Message-ID: <CAP8UFD0DoG5MR3V0eoy5LLf6mRBnthZMKjdmOiS8rhCQWRxoZw@mail.gmail.com> (raw) In-Reply-To: <firstname.lastname@example.org> Just a few nits that you can take into account if you reroll the patch for another reason, but I am not sure they are worth rerolling by themselves. On Thu, May 27, 2021 at 3:27 AM Matheus Tavares <email@example.com> wrote: > > t2080 makes a few copies of a test repository and later performs a > branch switch on each one of the copies to verify that parallel checkout > and sequential checkout produce the same results. However, the > repository is copied with `cp -R` which, on some systems, defaults to > following symlinks on the directory hierarchy and copying their target > files instead of copying the symlinks themselves. AIX is one example of > system where this happens. Because the symlinks are not preserved, the > copied repositories have paths that do not match what is in the index, > causing git to abort the checkout operation that we want to test. This s/git/Git/ > makes the test fail on these systems. > > Fix this by copying the repository with the POSIX flag '-P', which > forces cp to copy the symlinks instead of following them. Note that we > already use this flag for other cp invocations in our test suite (see > t7001). Maybe you could mention 00764ca10e (test: fix t7001 cp to use POSIX options, 2014-04-11) that also fixed t7001 in a similar way. > With this change, t2080 now passes on AIX. Thanks!
next prev parent reply other threads:[~2021-05-27 7:26 UTC|newest] Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-05-26 23:58 Matheus Tavares 2021-05-27 7:25 ` Christian Couder [this message] 2021-05-27 12:51 ` Ævar Arnfjörð Bjarmason 2021-05-31 14:01 ` Ævar Arnfjörð Bjarmason 2021-05-31 16:09 ` Matheus Tavares 2021-05-31 20:41 ` Ævar Arnfjörð Bjarmason 2021-06-02 1:36 ` Đoàn Trần Công Danh 2021-06-02 10:50 ` Ævar Arnfjörð Bjarmason 2021-06-02 11:14 ` Bagas Sanjaya 2021-06-02 11:22 ` Đoàn Trần Công Danh 2021-06-02 13:36 ` Ævar Arnfjörð Bjarmason 2021-06-02 13:50 ` Đoàn Trần Công Danh 2021-06-03 12:34 ` Đoàn Trần Công Danh 2021-06-02 19:13 ` UTF-BOM was: [PATCH] t2080: fix cp invocation Torsten Bögershausen 2021-06-03 0:07 ` [PATCH] t2080: fix cp invocation to copy symlinks instead of following them brian m. carlson
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=CAP8UFD0DoG5MR3V0eoy5LLf6mRBnthZMKjdmOiS8rhCQWRxoZw@mail.gmail.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --subject='Re: [PATCH] t2080: fix cp invocation to copy symlinks instead of following them' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).