Re: [GSoC] [PATCH 1/2] submodule--helper: introduce add-clone subcommand

From: Christian Couder <christian.couder@gmail.com>
To: Bagas Sanjaya <bagasdotme@gmail.com>
Cc: Atharva Raykar <raykar.ath@gmail.com>, git <git@vger.kernel.org>,
	Junio C Hamano <gitster@pobox.com>,
	Shourya Shukla <shouryashukla.oo@gmail.com>,
	Prathamesh Chavan <pc44800@gmail.com>
Subject: Re: [GSoC] [PATCH 1/2] submodule--helper: introduce add-clone subcommand
Date: Sun, 6 Jun 2021 11:06:05 +0200	[thread overview]
Message-ID: <CAP8UFD0oXjxRCXi12nVWtKWBm+tAOcRhZ5g+1tM8qP+5nKbLpQ@mail.gmail.com> (raw)
In-Reply-To: <2422ea94-473e-2fa9-a3cf-f22f941e9b44@gmail.com>

Hi,

On Sun, Jun 6, 2021 at 5:38 AM Bagas Sanjaya <bagasdotme@gmail.com> wrote:
>
> Hi,
>
> On 05/06/21 18.39, Atharva Raykar wrote:
> > +     git submodule--helper add-clone ${GIT_QUIET:+--quiet} ${force:+"--force"} ${progress:+"--progress"} ${branch:+--branch "$branch"} --prefix "$wt_prefix" --path "$sm_path" --name "$sm_name" --url "$realrepo" ${reference:+"$reference"} ${dissociate:+"--dissociate"} ${depth:+"$depth"} || exit
>
> What is the exit code you mean in case of error?

The exit code of the above is the same as the exit code of what's
before `|| exit`.

For example:

$ ( ( exit 10 ) || exit ); echo $?
10

> >       git config submodule."$sm_name".url "$realrepo"
> >
> >       git add --no-warn-embedded-repo $force "$sm_path" ||
>
> Is `git` executable that found in $PATH used? I have both
> distro-packaged Git and custom-compiled Git installed, and I would like
> the latter to be able to use git-submodule from its own install prefix
> (/path/to/git-prefix or whatsever).

This is a different issue than what this patch is doing.