Re: [PATCH v6] [GSOC] trailer: add new trailer.<token>.cmd config option

[Christian Couder <christian.couder@gmail.com>]

On Mon, Apr 5, 2021 at 1:26 AM Junio C Hamano <gitster@pobox.com> wrote:
>
> Christian Couder <christian.couder@gmail.com> writes:
>
> > On Fri, Apr 2, 2021 at 10:49 PM Junio C Hamano <gitster@pobox.com> wrote:
> >> ...
> >>         ... as if a '<token>=<value>' argument were added at the
> >>         beginning of the "git interpret-trailers" command, the
> >>         command specified by this configuration variable will be
> >>         called with an empty string as the argument.
> >>
> >> is my attempt,
> >
> > It looks better to me.
> >
> >> but I am not still sure what that "as if" part is
> >> trying to say.  Does it mean with
> >>
> >>         [trailer "Foo"] cmd = foo-cmd
> >>
> >> and the 'input-file' does not have "Foo: <some existing value>"
> >> trailer in it, the command "git interpret-trailers input-file"
> >> would behave as if this command was run
> >>
> >>         $ Foo= git interpret-trailers input-file
> >
> > I would say it would behave as if:
> >
> > $ git interpret-trailers --trailer Foo= input-file
>
> Hmmm.  That means that the descrition in the original is quite
> misleading, no?

Yeah, I agree it is misleading and difficult to understand.

> If it said
>
>         ... as if "--trailer" "<token>=<value>" arguments were given
>         to "git interpret-trailers" command near the beginning of
>         its command line
>
> then that may be closer description of the command line you are
> forming, but as its written (with or without my attempt to clarify
> above), it was impossible to infer that you are behaving as if
> another --trailer option (with <token>=<value> as its value) was
> given.

I agree.