git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Christian Couder <christian.couder@gmail.com>
To: Shourya Shukla <shouryashukla.oo@gmail.com>
Cc: Johannes Schindelin <Johannes.Schindelin@gmx.de>,
	Junio C Hamano <gitster@pobox.com>,
	Denton Liu <liu.denton@gmail.com>,
	Kaartic Sivaraam <kaartic.sivaraam@gmail.com>,
	Nguyen Thai Ngoc Duy <pclouds@gmail.com>,
	git <git@vger.kernel.org>
Subject: Re: [PATCH 3/4] diff: change scope of the function count_lines()
Date: Sat, 4 Jul 2020 23:46:54 +0200	[thread overview]
Message-ID: <CAP8UFD1PZ=S401xUAiwcC4LJ+m-X0L2Lv6jQ84OfTZD4hP0K_w@mail.gmail.com> (raw)
In-Reply-To: <20200704152802.GA46571@konoha>

On Sat, Jul 4, 2020 at 5:28 PM Shourya Shukla
<shouryashukla.oo@gmail.com> wrote:
>
> On 03/07 05:07, Johannes Schindelin wrote:

> > In addition, as with all such changes, we need to be careful to consider
> > whether unrelated function names coming in from system headers might
> > clash. In this case, I think `count_lines()` is a bit too generic, but
> > will probably not clash. Personally, I would probably have opted for
> > `count_lines_in_string()`.
>
> I do not see it clashing with any other functions. Do we need to change
> the name still (maybe to make the functions purpose even more clear)?

This patch might not be needed at all according to Dscho's review of
another patch in this series.

  reply	other threads:[~2020-07-04 21:47 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-02 19:24 [GSoC][PATCH 0/4] submodule: port 'summary' from Shell to C Shourya Shukla
2020-07-02 19:24 ` [PATCH 1/4] submodule: amend extra line feed between callback struct and macro Shourya Shukla
2020-07-03 14:57   ` Johannes Schindelin
2020-07-03 15:37     ` Philip Oakley
2020-07-04 15:21       ` Shourya Shukla
2020-07-04 15:39         ` Đoàn Trần Công Danh
2020-07-05 10:52           ` Philip Oakley
2020-07-02 19:24 ` [PATCH 2/4] submodule: rename helper functions to avoid ambiguity Shourya Shukla
2020-07-02 19:24 ` [PATCH 3/4] diff: change scope of the function count_lines() Shourya Shukla
2020-07-03 15:07   ` Johannes Schindelin
2020-07-04 15:28     ` Shourya Shukla
2020-07-04 21:46       ` Christian Couder [this message]
2020-07-02 19:24 ` [PATCH 4/4] submodule: port submodule subcommand 'summary' from shell to C Shourya Shukla
2020-07-03 20:46   ` Johannes Schindelin
2020-07-05 17:34     ` Shourya Shukla
2020-07-06  9:16       ` Kaartic Sivaraam
2020-07-06 11:15         ` Shourya Shukla
2020-07-12  0:46           ` Johannes Schindelin
2020-07-15 14:53             ` Shourya Shukla
2020-07-15 18:41               ` Shourya Shukla
2020-08-10 13:24                 ` Johannes Schindelin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAP8UFD1PZ=S401xUAiwcC4LJ+m-X0L2Lv6jQ84OfTZD4hP0K_w@mail.gmail.com' \
    --to=christian.couder@gmail.com \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=kaartic.sivaraam@gmail.com \
    --cc=liu.denton@gmail.com \
    --cc=pclouds@gmail.com \
    --cc=shouryashukla.oo@gmail.com \
    --subject='Re: [PATCH 3/4] diff: change scope of the function count_lines()' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).