From: Christian Couder <christian.couder@gmail.com>
To: git <git@vger.kernel.org>
Cc: Junio C Hamano <gitster@pobox.com>, Jeff King <peff@peff.net>,
Duy Nguyen <pclouds@gmail.com>,
Johannes Schindelin <Johannes.Schindelin@gmx.de>,
Stefan Beller <sbeller@google.com>,
Christian Couder <chriscool@tuxfamily.org>
Subject: Re: [PATCH v3 0/8] Add delta islands support
Date: Thu, 9 Aug 2018 21:34:09 +0200 [thread overview]
Message-ID: <CAP8UFD27LbAiperQTbm_unZvkoThv2JjfM4wa2n5Ay=E=ZM1+Q@mail.gmail.com> (raw)
In-Reply-To: <20180809155532.26151-1-chriscool@tuxfamily.org>
On Thu, Aug 9, 2018 at 5:55 PM, Christian Couder
<christian.couder@gmail.com> wrote:
> The following changes have been made since the previous iteration:
>
> * suggested by Duy: move the code computing the write order for a
> layer to a new separate function called compute_layer_order() in
> builtin/pack-objects.c in new patch 3/8
>
> I think that indeed this makes the following patch (4/8) shorter and
> easier to understand as well as the overall result nicer.
>
> * suggested by Duy and Peff: rework the way the 'tree_depth' field is
> moved from 'struct object_entry' to 'struct packing_data' in
> pack-object.h in patch 7/8
>
> * suggested by Duy and Peff: move field 'layer' from
> 'struct object_entry' to 'struct packing_data' in pack-object.h in
> new patch 8/8
I forgot to tell about the following change that is also part of the v3:
* suggested by Junio and Peff: increase the 'regmatch_t matches[]'
array from 8 to 16, advertise 14 group captures max, and add a warning
if the final element gets filled in in delta-islands.c in patch 2/8
prev parent reply other threads:[~2018-08-09 19:34 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-09 15:55 [PATCH v3 0/8] Add delta islands support Christian Couder
2018-08-09 15:55 ` [PATCH v3 1/8] packfile: make get_delta_base() non static Christian Couder
2018-08-09 15:55 ` [PATCH v3 2/8] Add delta-islands.{c,h} Christian Couder
2018-08-11 9:04 ` SZEDER Gábor
2018-08-11 10:32 ` Christian Couder
2018-08-11 14:12 ` Jeff King
2018-08-12 4:32 ` Christian Couder
2018-08-09 15:55 ` [PATCH v3 3/8] pack-objects: refactor code into compute_layer_order() Christian Couder
2018-08-09 15:55 ` [PATCH v3 4/8] pack-objects: add delta-islands support Christian Couder
2018-08-09 15:55 ` [PATCH v3 5/8] repack: " Christian Couder
2018-08-09 15:55 ` [PATCH v3 6/8] t: add t5319-delta-islands.sh Christian Couder
2018-08-09 15:55 ` [PATCH v3 7/8] pack-objects: move tree_depth into 'struct packing_data' Christian Couder
2018-08-09 15:55 ` [PATCH v3 8/8] pack-objects: move 'layer' " Christian Couder
2018-08-09 19:34 ` Christian Couder [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAP8UFD27LbAiperQTbm_unZvkoThv2JjfM4wa2n5Ay=E=ZM1+Q@mail.gmail.com' \
--to=christian.couder@gmail.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=chriscool@tuxfamily.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=pclouds@gmail.com \
--cc=peff@peff.net \
--cc=sbeller@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).