From: Christian Couder <christian.couder@gmail.com>
To: "René Scharfe" <l.s.r@web.de>
Cc: Junio C Hamano <gitster@pobox.com>,
Phillip Wood <phillip.wood123@gmail.com>,
Achu Luma <ach.lumap@gmail.com>,
git@vger.kernel.org, chriscool@tuxfamily.org, me@ttaylorr.com,
phillip.wood@dunelm.org.uk, steadmon@google.com
Subject: Re: [Outreachy][PATCH v5] Port helper/test-ctype.c to unit-tests/t-ctype.c
Date: Tue, 16 Jan 2024 20:45:09 +0100 [thread overview]
Message-ID: <CAP8UFD3=Jf3XAK1kZVNi0iR_9iE-rha-SZb2H2z4UeL51YPekA@mail.gmail.com> (raw)
In-Reply-To: <41cf1944-2456-4115-a934-aff2306a26e5@web.de>
On Tue, Jan 16, 2024 at 8:27 PM René Scharfe <l.s.r@web.de> wrote:
>
> Am 16.01.24 um 16:38 schrieb Junio C Hamano:
> > Phillip Wood <phillip.wood123@gmail.com> writes:
> >
> >> Thanks for adding back the test for EOF, this version looks good to me.
> >
> > Thanks. Let's merge it to 'next'.
>
> OK. I'm still interested in replies to my question in
> https://lore.kernel.org/git/a087f57c-ce72-45c7-8182-f38d0aca9030@web.de/,
> i.e. whether we should have one TEST per class or one per class and
> character -- or in a broader sense: What's the ideal scope of a TEST?
> But I can ask it again in the form of a follow-up patch.
I think one test per character per class would result in too much
detail in the output. Other than that I think it's better to address
your questions to the designers of the unit test framework rather than
to the authors of this patch. And yeah, sending a follow up patch
would perhaps be the best. Thanks.
next prev parent reply other threads:[~2024-01-16 19:45 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-21 23:15 [PATCH] Port helper/test-ctype.c to unit-tests/t-ctype.c Achu Luma
2023-12-26 18:45 ` Junio C Hamano
2023-12-27 10:57 ` Christian Couder
2023-12-27 11:57 ` René Scharfe
2023-12-27 14:40 ` Phillip Wood
2023-12-27 23:48 ` Junio C Hamano
2023-12-28 16:05 ` René Scharfe
2024-01-02 18:55 ` Taylor Blau
2023-12-30 0:09 ` [Outreachy][PATCH v2] " Achu Luma
2024-01-01 10:40 ` [Outreachy][PATCH v3] " Achu Luma
2024-01-01 16:41 ` René Scharfe
2024-01-02 16:35 ` Junio C Hamano
2024-01-05 16:14 ` [Outreachy][PATCH v4] " Achu Luma
2024-01-07 12:45 ` René Scharfe
2024-01-08 22:32 ` Junio C Hamano
2024-01-09 10:35 ` Phillip Wood
2024-01-09 17:12 ` Junio C Hamano
2024-01-12 10:27 ` [Outreachy][PATCH v5] " Achu Luma
2024-01-15 10:39 ` Phillip Wood
2024-01-16 15:38 ` Junio C Hamano
2024-01-16 19:27 ` René Scharfe
2024-01-16 19:45 ` Christian Couder [this message]
2024-01-16 19:52 ` Junio C Hamano
2024-01-17 5:37 ` Josh Steadmon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAP8UFD3=Jf3XAK1kZVNi0iR_9iE-rha-SZb2H2z4UeL51YPekA@mail.gmail.com' \
--to=christian.couder@gmail.com \
--cc=ach.lumap@gmail.com \
--cc=chriscool@tuxfamily.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=l.s.r@web.de \
--cc=me@ttaylorr.com \
--cc=phillip.wood123@gmail.com \
--cc=phillip.wood@dunelm.org.uk \
--cc=steadmon@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).