From: Christian Couder <christian.couder@gmail.com> To: Junio C Hamano <gitster@pobox.com> Cc: ZheNing Hu via GitGitGadget <gitgitgadget@gmail.com>, git <git@vger.kernel.org>, Jeff King <peff@peff.net>, Hariom Verma <hariom18599@gmail.com>, ZheNing Hu <adlternative@gmail.com> Subject: Re: [PATCH v2 2/2] [GSOC] ref-filter: introduce enum atom_type Date: Tue, 11 May 2021 07:51:44 +0200 [thread overview] Message-ID: <CAP8UFD3m0TA3nPDaPhaU3=FVF_r5cPM8xksVL6MpCOhNC4dT3g@mail.gmail.com> (raw) In-Reply-To: <xmqqh7jaow31.fsf@gitster.g> On Tue, May 11, 2021 at 4:14 AM Junio C Hamano <gitster@pobox.com> wrote: > > "ZheNing Hu via GitGitGadget" <gitgitgadget@gmail.com> writes: > > +/* > > + * The enum atom_type is used as the coordinates of valid_atom entry. > > + * In the atom parsing stage, it will be passed to used_atom.atom_type > > + * as the identifier of the atom type. We can judge the type of used_atom > > + * entry by `if (used_atom[i].atom_type == ATOM_*)`. > > + * > > + * ATOM_UNKNOWN equals to 0, used as an enumeration value of uninitialized > > + * atom_type. > > Shouldn't it be (-1)? If it's -1 instead of 0, then it might be a bit more complex to initialize structs that contain such a field, as it cannot be done with only xcalloc(). > And I'd assume I am right in the following. > > > + * ATOM_INVALID equals to the size of valid_atom array, which could help us > > + * iterate over valid_atom array like this: > > + * > > + * for (i = ATOM_UNKNOWN + 1; i < ATOM_INVALID; i++) { > > I find it far more intuitive to say > > for (i = 0; i < ATOM_INVALID; i++) > > than having to say UNKNOWN+1. Yeah, that's more intuitive. But in my opinion, using `ATOM_UNKNOWN + 1` instead of `0` at least shouldn't often result in more lines of code, and should be a bit easier to get right, compared to having to initialize the field with ATOM_UNKNOWN. > In any case, the values should be indented, and a comment should > ensure that the final one stays at the end, perhaps like this. > > enum atom_type { > ATOM_INVALID = -2, > ATOM_UNKNOWN = -1, > ATOM_REFNAME, > ... > ATOM_ELSE, > ATOM_MAX /* MUST BE AT THE END */ I agree that a comment telling people that it must be at the end is good. > } > > (note that the trailing comma is deliberately omitted). Yeah. > It would allow people to say > > for (i = 0; i < ATOM_MAX; i++) > > instead, which would be even nicer. Yeah, it's also a tradeoff to have the last one called ATOM_MAX instead of ATOM_INVALID, and to have a separate ATOM_INVALID if it's needed.
next prev parent reply other threads:[~2021-05-11 5:56 UTC|newest] Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-05-08 15:22 [PATCH 0/2] [GSOC][RFC] " ZheNing Hu via GitGitGadget 2021-05-08 15:22 ` [PATCH 1/2] [GSOC] ref-filter: add objectsize to used_atom ZheNing Hu via GitGitGadget 2021-05-08 15:22 ` [PATCH 2/2] [GSOC][RFC] ref-filter: introduce enum atom_type ZheNing Hu via GitGitGadget 2021-05-09 6:21 ` Christian Couder 2021-05-09 8:26 ` Junio C Hamano 2021-05-09 13:44 ` ZheNing Hu 2021-05-09 13:40 ` ZheNing Hu 2021-05-10 15:03 ` [PATCH v2 0/2] " ZheNing Hu via GitGitGadget 2021-05-10 15:03 ` [PATCH v2 1/2] [GSOC] ref-filter: add objectsize to used_atom ZheNing Hu via GitGitGadget 2021-05-10 15:03 ` [PATCH v2 2/2] [GSOC] ref-filter: introduce enum atom_type ZheNing Hu via GitGitGadget 2021-05-11 2:14 ` Junio C Hamano 2021-05-11 5:51 ` Christian Couder [this message] 2021-05-11 6:12 ` Junio C Hamano 2021-05-11 12:53 ` ZheNing Hu 2021-05-11 12:37 ` ZheNing Hu 2021-05-11 13:05 ` Junio C Hamano 2021-05-11 12:18 ` ZheNing Hu 2021-05-12 12:11 ` [PATCH v3 0/2] [GSOC][RFC] " ZheNing Hu via GitGitGadget 2021-05-12 12:11 ` [PATCH v3 1/2] [GSOC] ref-filter: add objectsize to used_atom ZheNing Hu via GitGitGadget 2021-05-12 23:11 ` Junio C Hamano 2021-05-13 9:04 ` ZheNing Hu 2021-05-12 12:11 ` [PATCH v3 2/2] [GSOC] ref-filter: introduce enum atom_type ZheNing Hu via GitGitGadget 2021-05-12 23:21 ` Junio C Hamano 2021-05-13 9:25 ` ZheNing Hu 2021-05-13 15:15 ` [PATCH v4 0/2] [GSOC][RFC] " ZheNing Hu via GitGitGadget 2021-05-13 15:15 ` [PATCH v4 1/2] [GSOC] ref-filter: add objectsize to used_atom ZheNing Hu via GitGitGadget 2021-05-13 15:15 ` [PATCH v4 2/2] [GSOC] ref-filter: introduce enum atom_type ZheNing Hu via GitGitGadget
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CAP8UFD3m0TA3nPDaPhaU3=FVF_r5cPM8xksVL6MpCOhNC4dT3g@mail.gmail.com' \ --to=christian.couder@gmail.com \ --cc=adlternative@gmail.com \ --cc=git@vger.kernel.org \ --cc=gitgitgadget@gmail.com \ --cc=gitster@pobox.com \ --cc=hariom18599@gmail.com \ --cc=peff@peff.net \ --subject='Re: [PATCH v2 2/2] [GSOC] ref-filter: introduce enum atom_type' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).