git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Tao Klerks <tao@klerks.biz>
To: Derrick Stolee <stolee@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: Partial Clone, and a strange slow rev-list call on fetch
Date: Sat, 5 Jun 2021 08:35:02 +0200	[thread overview]
Message-ID: <CAPMMpojV6McG-mc1xwuC0CEY5_E7=PBGQF-ijhb-EP4T=6Qu7w@mail.gmail.com> (raw)
In-Reply-To: <5ce5286c-9390-7cb5-a039-8e26be990b8d@gmail.com>

On Fri, Jun 4, 2021 at 3:21 PM Derrick Stolee <stolee@gmail.com> wrote:
> You
> have convinced me that there are deeper things going on than just
> the "unshallow, but with filters this time" situation.
>
> I have created an internal issue for my team to investigate this
> when we have capacity for it.

Awesome, thanks!

One more comment on this: As I was trawling through release notes
looking for the right minimum git client version to target/support, I
discovered that the whole "fetch shallow, then unshallow filtered"
flow, which I might have thought I came up with on my own, was
intended to be supported with a change Xin Li made about a year ago,
and landed in 2.28.0:
https://github.com/git/git/commit/01bbbbd9daaa277a95ae46e5a32f6fba026610ac.

As far as I can tell this implementation/behavior does *not* attempt
to convert existing non-promisor packfiles to promisor packfiles, so
either this behavior should be adjusted to do so, or we should
consider this flow (and the presence of non-promisor packfiles at the
"tip") supported...?

      reply	other threads:[~2021-06-05  6:36 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-02  4:56 Tao Klerks
2021-06-02 11:18 ` Derrick Stolee
2021-06-03 21:10   ` Tao Klerks
2021-06-04 13:21     ` Derrick Stolee
2021-06-05  6:35       ` Tao Klerks [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAPMMpojV6McG-mc1xwuC0CEY5_E7=PBGQF-ijhb-EP4T=6Qu7w@mail.gmail.com' \
    --to=tao@klerks.biz \
    --cc=git@vger.kernel.org \
    --cc=stolee@gmail.com \
    --subject='Re: Partial Clone, and a strange slow rev-list call on fetch' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).