From: George Espinoza <firstname.lastname@example.org>
To: Junio C Hamano <email@example.com>
Cc: george espinoza via GitGitGadget <firstname.lastname@example.org>,
Git List <email@example.com>
Subject: Re: [PATCH 1/1] [Outreachy] merge-ours: include parse-options
Date: Wed, 30 Oct 2019 02:53:43 -0700 [thread overview]
Message-ID: <CAP_ANimgFVuq1U6xB=UMQZ-uQp2PayuD82EBAup20eZK3Fv8AA@mail.gmail.com> (raw)
On Tue, Oct 29, 2019 at 7:05 PM Junio C Hamano <firstname.lastname@example.org> wrote:
> "george espinoza via GitGitGadget" <email@example.com> writes:
> > From: george espinoza <firstname.lastname@example.org>
> > Teach this command which currently handles its own argv to use
> > parse-options instead because parse-options helps make sure we handle
> > user input like -h in a standardized way across the project.
> Sorry, but why do we even want to do this? merge-ours is an
> implementation detail of "git merge" and is never run directly by
Hello Junio, this is my mistake. I am a first time contributor.
I'm currently working on Micro Project #3 as an Outreachy applicant
that states, "Teach a command which currently handles its own argv
how to use parse-options instead."
I was under the impression that all commands with the NOPARSE_OPT
flag in git.c needed parse-options added. I now see that I should take into
account for commands that are only ran by end-users :)
> I am not sure why it even needs "-h" in the first place, but that is
> already there, so letting sleeping dog lie would be what I would
> Is there a plan to add some -Xmerge-backend-option to this program,
> and would use of parse-options API make it easier? That would be a
> good reason to start using it in this program, but otherwise...
I will look into finding another command to contribute to instead after
your feedback so I can fulfill Micro Project #3 since I had not thought of
further plans past the parse-option replacement. Thank you for your input!
next prev parent reply other threads:[~2019-10-30 9:53 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-28 23:42 [PATCH 0/1] [Outreachy] merge-ours: include a parse-option George Espinoza via GitGitGadget
2019-10-28 23:42 ` [PATCH 1/1] [Outreachy] merge-ours: include parse-options george espinoza via GitGitGadget
2019-10-29 12:56 ` Johannes Schindelin
2019-10-29 20:42 ` Emily Shaffer
2019-10-30 9:43 ` George Espinoza
2019-10-30 2:05 ` Junio C Hamano
2019-10-30 9:53 ` George Espinoza [this message]
2019-10-30 21:58 ` Johannes Schindelin
2019-11-02 4:14 ` Junio C Hamano
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).