git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "‍우승훈[ 대학원석·박사통합과정수료 / 컴퓨터학과 ]" <seunghoonwoo@korea.ac.kr>
To: git@vger.kernel.org
Subject: Possible bug reports for git-credential-libsecret
Date: Thu, 10 Mar 2022 02:53:44 +0900	[thread overview]
Message-ID: <CAPb83E-1Ken14G9xdyw9MqZ6AiAZkwDuwRf_5NmqoUEvHcAqYQ@mail.gmail.com> (raw)

Dear Git Development team

Hi.
Recently, I noted that the vulnerability patch (CVE-2020-5260) for
"git credential" is not applied in the "git-credential-libsecret"
program (./contrib/credential/libsecret/git-credential-libsecret.c).

Actually, I'm not sure whether "git-credential-libsecret" is actually
used. But it can be potentially intimidating, thus it would be good to
apply the same patch of "git credential" to
"git-credential-libsecret".

- Patch for CVE-2020-5260
   * https://github.com/git/git/commit/9a6bbee8006c24b46a85d29e7b38cfa79e9ab21b

- Similar but not patched code in "git-credential-libsecret"
   * https://github.com/git/git/blob/master/contrib/credential/libsecret/git-credential-libsecret.c#L306-L311
   * When I put the malicious URL in the test code shown in the
CVE-2020-5260 patch into "git-credential-libsecret", it does not
terminate.

Could you please check whether this is an actual bug?

Thank you.
Best regards,
Seunghoon Woo
-- 

Best regards,

Seunghoon Woo
Korea University Dept. of Computer Science and Engineering
Computer & Communication Security Lab.
seunghoonwoo@korea.ac.kr
(+82)10-8147-9308

             reply	other threads:[~2022-03-09 17:52 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-09 17:53 ‍우승훈[ 대학원석·박사통합과정수료 / 컴퓨터학과 ] [this message]
2022-03-18 17:15 Possible bug reports for git-credential-libsecret ‍우승훈[ 대학원석·박사통합과정수료연구(재학) / 컴퓨터학과 ]
2022-03-18 17:40 ` Junio C Hamano
2022-03-18 18:19   ` ‍우승훈[ 대학원석·박사통합과정수료연구(재학) / 컴퓨터학과 ]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAPb83E-1Ken14G9xdyw9MqZ6AiAZkwDuwRf_5NmqoUEvHcAqYQ@mail.gmail.com \
    --to=seunghoonwoo@korea.ac.kr \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).