From: Eric Sunshine <sunshine@sunshineco.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Git List <git@vger.kernel.org>
Subject: Re: [PATCH] t0005: ksh93 portability workaround
Date: Tue, 31 May 2016 18:49:41 -0400 [thread overview]
Message-ID: <CAPig+cRD8aTNJxvfkc-5Xjr6_pKRzAi3SpZ7JCZcRYMQFT_xMg@mail.gmail.com> (raw)
In-Reply-To: <xmqqinxt3kwq.fsf@gitster.mtv.corp.google.com>
On Tue, May 31, 2016 at 6:47 PM, Junio C Hamano <gitster@pobox.com> wrote:
> The test has two things ksh93 does not happy about:
s/does/is/
> * It thinks "(( command1; command2 ) | command3)" is a perfectly
> sane way to write a pipeline. ksh93, unlike other POSIX shells,
> does not like the two open parentheses next to each other for
> whatever reason it has.
>
> * It adds 256, unlike 128 that are used by other POSIX shells, to
> the signal number that caused the process to die when coming up
> with the exit status.
>
> What is interesting is that we knew about the latter issue and had a
> workaround in the test-sigchain test when verifying that SIGTERM
> works OK, but we didn't have corresponding workaround for SIGPIPE.
>
> Signed-off-by: Junio C Hamano <gitster@pobox.com>
next prev parent reply other threads:[~2016-05-31 22:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-31 22:47 [PATCH] t0005: ksh93 portability workaround Junio C Hamano
2016-05-31 22:49 ` Eric Sunshine [this message]
2016-05-31 23:03 ` Jeff King
2016-05-31 23:17 ` Junio C Hamano
2016-05-31 23:04 ` [PATCH] t/lib-git-daemon: ksh " Junio C Hamano
2016-05-31 23:05 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPig+cRD8aTNJxvfkc-5Xjr6_pKRzAi3SpZ7JCZcRYMQFT_xMg@mail.gmail.com \
--to=sunshine@sunshineco.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).