From: Eric Sunshine <sunshine@sunshineco.com>
To: Denton Liu <liu.denton@gmail.com>
Cc: Git Mailing List <git@vger.kernel.org>,
Johannes Schindelin <Johannes.Schindelin@gmx.de>,
Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH 1/7] Makefile: mark 'check-builtins' as a .PHONY target
Date: Tue, 16 Mar 2021 00:59:15 -0400 [thread overview]
Message-ID: <CAPig+cS900W=tu_=2dA4hGjRXnNDTEc=Ne4Rb=y9wy_C_4Js7w@mail.gmail.com> (raw)
In-Reply-To: <c889973be754336005d0155ce670f16e322df9c3.1615856156.git.liu.denton@gmail.com>
On Mon, Mar 15, 2021 at 8:57 PM Denton Liu <liu.denton@gmail.com> wrote:
> Then convention in Git's Makefile is to mark targets which do not
s/Then/The/
> actually generate any precious files (such as static checking targets).
> .PHONY enables the target to still run, even if a file is erroneously
> created with the same name as the target.
>
> Mark 'check-builtins' as a .PHONY target.
>
> Signed-off-by: Denton Liu <liu.denton@gmail.com>
next prev parent reply other threads:[~2021-03-16 5:00 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-16 0:56 [PATCH 0/7] Sort lists and add static-analysis Denton Liu
2021-03-16 0:56 ` [PATCH 1/7] Makefile: mark 'check-builtins' as a .PHONY target Denton Liu
2021-03-16 4:59 ` Eric Sunshine [this message]
2021-03-17 17:47 ` Junio C Hamano
2021-03-16 0:56 ` [PATCH 2/7] Makefile: ASCII-sort LIB_OBJS Denton Liu
2021-03-16 0:56 ` [PATCH 3/7] builtin.h: ASCII-sort list of functions Denton Liu
2021-03-17 17:51 ` Junio C Hamano
2021-03-16 0:56 ` [PATCH 4/7] test-tool.h: " Denton Liu
2021-03-17 17:54 ` Junio C Hamano
2021-03-16 0:56 ` [PATCH 5/7] Makefile: add 'check-sort' target Denton Liu
2021-03-16 6:37 ` Eric Sunshine
2021-03-17 9:50 ` Denton Liu
2021-03-17 12:47 ` Ævar Arnfjörð Bjarmason
2021-03-17 17:32 ` Jeff King
2021-03-17 17:42 ` Ævar Arnfjörð Bjarmason
2021-03-17 21:48 ` Eric Sunshine
2021-03-17 22:01 ` Jeff King
2021-03-17 18:01 ` Junio C Hamano
2021-03-17 18:16 ` Ævar Arnfjörð Bjarmason
2021-03-17 17:59 ` Junio C Hamano
2021-03-16 0:56 ` [PATCH 6/7] ci/run-static-analysis.sh: make check-builtins Denton Liu
2021-03-16 0:56 ` [PATCH 7/7] ci/run-static-analysis.sh: make check-sort Denton Liu
2021-03-17 11:01 ` [PATCH 0/7] Sort lists and add static-analysis Bagas Sanjaya
2021-03-17 18:05 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPig+cS900W=tu_=2dA4hGjRXnNDTEc=Ne4Rb=y9wy_C_4Js7w@mail.gmail.com' \
--to=sunshine@sunshineco.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=liu.denton@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).