git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Eric Sunshine <sunshine@sunshineco.com>
To: Lance Ward <ljward10@gmail.com>
Cc: Junio C Hamano <gitster@pobox.com>,
	Lance Ward via GitGitGadget <gitgitgadget@gmail.com>,
	Git List <git@vger.kernel.org>
Subject: Re: [PATCH] status: fix verbose status coloring inconsistency
Date: Fri, 5 Feb 2021 02:06:12 -0500	[thread overview]
Message-ID: <CAPig+cSqhopq1ibWFYuWwV=fET+MYdyusvwGdcvj-pdy6LXbGQ@mail.gmail.com> (raw)
In-Reply-To: <CACPHW2WxXKaDjMY3KdxAQAi82V3_crN763bGQa4aWcJttZ+_cQ@mail.gmail.com>

On Wed, Feb 3, 2021 at 7:44 PM Lance Ward <ljward10@gmail.com> wrote:
> On Wed, Feb 3, 2021 at 4:51 PM Junio C Hamano <gitster@pobox.com> wrote:
> > Our log message begins with the description of the current status,
> > so "Currently" is not something you need to say.
>
> I'm disappointed by your tone...
>
> I'll go ahead and close my pull requests, if someone else wants
> to pick them up that's fine with me.

It is, unfortunately, easy to misinterpret a reviewer's neutral tone
as being negative or as an attempt to shame the author. But be assured
that the goal of reviewers on this project is to help the patch author
get the submission into proper shape for acceptance, and when Junio
takes the time to write such a comprehensive review, he does so
because he sees promise in both the patches and in the author of the
patches. A review as extensive as this one is intended to get the
newcomer up to speed quickly with local project conventions (such as
how commit messages are written) and to help land the patches with as
few revisions as possible since both submitter and reviewer time is
valuable.

  reply	other threads:[~2021-02-05  7:07 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-03 21:34 [PATCH] status: fix verbose status coloring inconsistency Lance Ward via GitGitGadget
2021-02-03 22:51 ` Junio C Hamano
2021-02-04  0:44   ` Lance Ward
2021-02-05  7:06     ` Eric Sunshine [this message]
2021-02-05  7:17   ` Eric Sunshine

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAPig+cSqhopq1ibWFYuWwV=fET+MYdyusvwGdcvj-pdy6LXbGQ@mail.gmail.com' \
    --to=sunshine@sunshineco.com \
    --cc=git@vger.kernel.org \
    --cc=gitgitgadget@gmail.com \
    --cc=gitster@pobox.com \
    --cc=ljward10@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).