From: Eric Sunshine <sunshine@sunshineco.com>
To: gitgitgadget@gmail.com
Cc: Git List <git@vger.kernel.org>, Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH 0/1] Add coverage for 'git format-patch --range-diff' single-patch case
Date: Tue, 11 Sep 2018 17:21:00 -0400 [thread overview]
Message-ID: <CAPig+cT4HeX85SXZgyVQpAZarDFaafeBri7zLpExA=3O403qRw@mail.gmail.com> (raw)
In-Reply-To: <pull.37.git.gitgitgadget@gmail.com>
On Tue, Sep 11, 2018 at 4:26 PM Derrick Stolee via GitGitGadget
<gitgitgadget@gmail.com> wrote:
> In es/format-patch-rangediff, we added a '--range-diff' option to
> git-format-patch to automatically add a range-diff. We also added an option
> to write the diff as commentary to a single patch submission. However, this
> check was not tested.
It was an intentional (though unjustified) oversight. Thanks for
working on this.
> I discovered this test gap by running 'make coverage-test coverage-report'
> on 'next' and then comparing the uncovered lines with those in the diff
> between 'master' and 'next'. I have a script that automates this process,
> and I'm still working on polishing it.
Interesting. Does your script detect that the --creation-factor option
added by patch 13/14 [1] also lacks a test? (I'm not necessarily
suggesting adding a test at the moment. Even Dscho's git-range-diff
series doesn't have a test for "creation factor", so it wouldn't
necessarily make sense to add a test only for the git-format-patch
case. Instead, we'd want, at some point, to add tests covering both
git-range-diff and git-format-patch.)
[1]: https://public-inbox.org/git/20180722095717.17912-14-sunshine@sunshineco.com/
next prev parent reply other threads:[~2018-09-11 21:21 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-11 20:21 [PATCH 0/1] Add coverage for 'git format-patch --range-diff' single-patch case Derrick Stolee via GitGitGadget
2018-09-11 20:21 ` [PATCH 1/1] t3206-range-diff.sh: cover " Derrick Stolee via GitGitGadget
2018-09-11 20:58 ` Junio C Hamano
2018-09-11 21:11 ` Junio C Hamano
2018-09-11 21:09 ` Stefan Beller
2018-09-11 21:34 ` Eric Sunshine
2018-09-12 14:20 ` Derrick Stolee
2018-09-11 20:29 ` [PATCH 0/1] Add coverage for 'git format-patch --range-diff' " Derrick Stolee
2018-09-11 21:21 ` Eric Sunshine [this message]
2018-09-12 14:31 ` [PATCH v2 " Derrick Stolee via GitGitGadget
2018-09-12 14:31 ` [PATCH v2 1/1] t3206-range-diff.sh: cover " Derrick Stolee via GitGitGadget
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPig+cT4HeX85SXZgyVQpAZarDFaafeBri7zLpExA=3O403qRw@mail.gmail.com' \
--to=sunshine@sunshineco.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).