From: Eric Sunshine <sunshine@sunshineco.com>
To: Jonathan Nieder <jrnieder@gmail.com>
Cc: "Michael S. Tsirkin" <mst@redhat.com>, Git List <git@vger.kernel.org>
Subject: Re: [PATCH v2] contrib: git-cpcover: copy cover letter
Date: Wed, 4 Dec 2019 00:18:28 -0500 [thread overview]
Message-ID: <CAPig+cTFbpAo5+kahLT+7E1zQe24S5icm0SSB=HF4xqsD2VdAA@mail.gmail.com> (raw)
In-Reply-To: <20191204044449.GB226135@google.com>
On Tue, Dec 3, 2019 at 11:45 PM Jonathan Nieder <jrnieder@gmail.com> wrote:
> Michael S. Tsirkin wrote:
> > My flow looks like this:
> > 2. vi <dir>/v<n-1>-0000-cover-letter.patch <dir>/v<n>-0000-cover-letter.patch
> > copy subject and blurb, avoiding patchset stats
> > 3. add changelog update blurb as appropriate
> >
> > The following perl script automates step 2 above.
>
> Neat. I wonder, should "git format-patch" learn an option for this?
> git format-patch -v<n> --cover-letter \
> --last-cover-letter=<dir>/v<n-1>-0000-cover-letter.patch \
> -o <dir>
That was my first thought, as well, although, as this has similar
purpose to the new git-format-patch --cover-from-description= option,
perhaps a more suitable name might be --copy-cover-from= or something?
I could even imagine a new option -V<n> which has the combined effect
of setting the re-roll count (like -v) and automagically copying the
cover letter material from cover letter v<n-1> located in <dir>.
next prev parent reply other threads:[~2019-12-04 5:18 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-03 20:13 [PATCH v2] contrib: git-cpcover: copy cover letter Michael S. Tsirkin
2019-12-04 4:44 ` Jonathan Nieder
2019-12-04 5:18 ` Eric Sunshine [this message]
2019-12-04 16:22 ` Junio C Hamano
2019-12-04 16:32 ` Eric Sunshine
2019-12-04 17:07 ` Junio C Hamano
2019-12-09 15:49 ` Michael S. Tsirkin
2019-12-04 6:58 ` Denton Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPig+cTFbpAo5+kahLT+7E1zQe24S5icm0SSB=HF4xqsD2VdAA@mail.gmail.com' \
--to=sunshine@sunshineco.com \
--cc=git@vger.kernel.org \
--cc=jrnieder@gmail.com \
--cc=mst@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).