From: Eric Sunshine <sunshine@sunshineco.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Git List <git@vger.kernel.org>
Subject: Re: What's cooking in git.git (Jun 2018, #04; Fri, 15)
Date: Fri, 15 Jun 2018 16:49:58 -0400 [thread overview]
Message-ID: <CAPig+cTFhkKiMjjOTaFCuiyQC96oH8V-d1adFmyeHfDsB5gr7A@mail.gmail.com> (raw)
In-Reply-To: <xmqqd0wrztgh.fsf@gitster-ct.c.googlers.com>
On Fri, Jun 15, 2018 at 4:27 PM Junio C Hamano <gitster@pobox.com> wrote:
> * es/make-no-iconv (2018-06-15) 1 commit
> - Makefile: make NO_ICONV really mean "no iconv"
>
> "make NO_ICONV=NoThanks" did not override NEEDS_LIBICONV
Nit: The double-negative is a bit confusing. s/NoThanks/YesPlease/
would be easier to grok and would be more idiomatic (taking
config.mak.uname into account).
> (i.e. linkage of -lintl, -liconv, etc. that are platform-specific
> tweaks), which has been corrected.
prev parent reply other threads:[~2018-06-15 20:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-15 20:27 What's cooking in git.git (Jun 2018, #04; Fri, 15) Junio C Hamano
2018-06-15 20:49 ` Eric Sunshine [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPig+cTFhkKiMjjOTaFCuiyQC96oH8V-d1adFmyeHfDsB5gr7A@mail.gmail.com \
--to=sunshine@sunshineco.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).