From: Eric Sunshine <sunshine@sunshineco.com>
To: Andrei Rybak <rybak.a.v@gmail.com>
Cc: git@vger.kernel.org, Jeff Hostetler <jeffhost@microsoft.com>
Subject: Re: [PATCH] *: fix typos which duplicate a word
Date: Fri, 6 Jan 2023 13:25:11 -0500 [thread overview]
Message-ID: <CAPig+cTgUPWxMox_nSka52dML6_GHUUoY4HCtcq7+7J0oEyeNw@mail.gmail.com> (raw)
In-Reply-To: <20230106131304.20779-1-rybak.a.v@gmail.com>
On Fri, Jan 6, 2023 at 8:16 AM Andrei Rybak <rybak.a.v@gmail.com> wrote:
> Fix typos in code comments which repeat various words. Most of the
> cases are simple in that they repeat a word that usually cannot be
> repeated in a grammatically correct sentence. Just remove the
> incorrectly duplicated word in these cases and rewrap text, if needed.
>
> Reword code comment "entries exist on on-disk index" in function
> update_one in file cache-tree.c, by replacing incorrect preposition "on"
> with "in".
Thanks, these all look sensible.
> A tricky case is usage of "that that", which is sometimes grammatically
> correct. However, an instance of this in "t7527-builtin-fsmonitor.sh"
> doesn't need two words "that", because there is only one daemon being
> discussed, so the word "daemon" does not need a determiner.
But...
> Signed-off-by: Andrei Rybak <rybak.a.v@gmail.com>
> ---
> diff --git a/t/t7527-builtin-fsmonitor.sh b/t/t7527-builtin-fsmonitor.sh
> @@ -922,7 +922,7 @@ test_expect_success CASE_INSENSITIVE_FS 'case insensitive+preserving' '
> - # Rename .git using an alternate spelling to verify that that
> + # Rename .git using an alternate spelling to verify that
> # daemon detects it and automatically shuts down.
> mv test_insensitive/.GIT test_insensitive/.FOO &&
... this doesn't read as well following the change. It would read well
if you changed it to "that the".
Not related to your patch at all, but I notice in this test that the
call to test_when_finished() is commented out:
# test_when_finished "stop_daemon_delete_repo test_insensitive" &&
which makes me wonder if it was commented out while the test was being
debugged but then forgotten, and that the script is now potentially
leaking a running daemon if something in the test fails after the
daemon was started, or if the daemon does not shut down on its own as
it's supposed to do. [cc:+Jeff Hostetler]
next prev parent reply other threads:[~2023-01-06 18:25 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-06 13:13 [PATCH] *: fix typos which duplicate a word Andrei Rybak
2023-01-06 18:25 ` Eric Sunshine [this message]
2023-01-07 13:56 ` [PATCH v2] " Andrei Rybak
2023-01-08 1:29 ` Junio C Hamano
2023-01-06 22:37 ` [PATCH] " Junio C Hamano
-- strict thread matches above, loose matches on Subject: below --
2021-06-09 10:26 [PATCH] " Andrei Rybak
2021-06-09 15:28 ` Eric Sunshine
2021-06-09 17:31 ` Felipe Contreras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPig+cTgUPWxMox_nSka52dML6_GHUUoY4HCtcq7+7J0oEyeNw@mail.gmail.com \
--to=sunshine@sunshineco.com \
--cc=git@vger.kernel.org \
--cc=jeffhost@microsoft.com \
--cc=rybak.a.v@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).