archive mirror
 help / color / mirror / Atom feed
From: Matthias Lederhofer <>
To: Johannes Schindelin <>
Subject: Re: [PATCH] pager: config variable pager.color
Date: Sun, 30 Jul 2006 02:43:47 +0200	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

Johannes Schindelin <> wrote:
> Why? The three users of cmd_log_walk() need to call setup_pager() 
> explicitely, when cmd_log_walk() can do it for them?

The explanation is below the commit message:
"setup_pager has to be called before git_diff_ui_config because the
latter uses pager_use_color initialized by setup_pager."

> Oh, and I do not really understand why you would enable color _at all_ if 
> you want to disable it when paging. Do you have many instances when you 
> want a color diff which is short enough not to be paged?
When I use a pager that escapes the escape character or highlights the
content itself the output of git diff without the pager should have
colors but not with the pager.  For example using git diff with a
pathspec is quite short most of the time.  For git diff I have to
enable paging manually and run git diff | $PAGER usually but git log
uses the pager automatically and should not use colors with it.

  reply	other threads:[~2006-07-30  0:43 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-07-29 22:27 [PATCH] pager: config variable pager.color Matthias Lederhofer
2006-07-29 23:15 ` Johannes Schindelin
2006-07-30  0:43   ` Matthias Lederhofer [this message]
2006-07-30  9:33     ` Johannes Schindelin
2006-07-31  0:43     ` Junio C Hamano
2006-07-31  8:55       ` Juergen Ruehle
2006-07-31  9:53         ` Junio C Hamano
2006-07-31 12:02           ` Matthias Lederhofer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).