From: xiaoqiang zhao <zxq_yx_007@163.com>
To: Stefan Beller <sbeller@google.com>
Cc: sunshine@sunshineco.com, artagnon@gmail.com, avarab@gmail.com,
git@vger.kernel.org, gitster@pobox.com, mina86@mina86.com,
mst@kernel.org, pbonzini@redhat.com, viktorin@rehivetech.com
Subject: Re: [PATCH] send-email: error out when relogin delay is missing
Date: Thu, 8 Feb 2018 13:45:40 +0800 [thread overview]
Message-ID: <E5979434-8F78-496C-9364-3663FC3670F1@163.com> (raw)
In-Reply-To: <20180207234359.31493-1-sbeller@google.com>
> 在 2018年2月8日,上午7:43,Stefan Beller <sbeller@google.com> 写道:
>
> +die __("When a batch size is given, the relogin delay must be set\n")
> + if defined $relogin_delay and not defined $batch_size;
> +
According the code, maybe you want to say “When relogin delay is given, a batch size must be set “ ?
next prev parent reply other threads:[~2018-02-08 5:46 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-21 12:59 [PATCH v5] send-email: --batch-size to work around some SMTP server limit xiaoqiang zhao
2017-05-22 2:14 ` Junio C Hamano
2017-05-22 3:19 ` Zhaoxiangqiang
2018-02-07 19:45 ` [PATCH] send-email: have default batch size when relogin delay is given Stefan Beller
2018-02-07 19:50 ` Eric Sunshine
2018-02-07 23:43 ` [PATCH] send-email: error out when relogin delay is missing Stefan Beller
2018-02-08 5:45 ` xiaoqiang zhao [this message]
2018-02-08 8:08 ` Eric Sunshine
2018-02-08 18:21 ` Stefan Beller
2018-02-08 22:00 ` Eric Sunshine
2018-02-12 19:44 ` Stefan Beller
2017-05-22 9:26 ` [PATCH v5] send-email: --batch-size to work around some SMTP server limit Ævar Arnfjörð Bjarmason
2017-05-23 7:46 ` Junio C Hamano
2017-05-23 8:30 ` Jan Viktorin
2017-05-23 12:55 ` 赵小强
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E5979434-8F78-496C-9364-3663FC3670F1@163.com \
--to=zxq_yx_007@163.com \
--cc=artagnon@gmail.com \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=mina86@mina86.com \
--cc=mst@kernel.org \
--cc=pbonzini@redhat.com \
--cc=sbeller@google.com \
--cc=sunshine@sunshineco.com \
--cc=viktorin@rehivetech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).