From: Jonathon Mah <jmah@me.com>
To: "git@vger.kernel.org" <git@vger.kernel.org>
Cc: "Nathan Broadbent" <nathan.f77@gmail.com>
Subject: Re: Revert option for git add --patch
Date: Thu, 8 Nov 2012 00:57:19 -0800 [thread overview]
Message-ID: <EE89F0A1-1C07-4597-B654-035F657AD09F@me.com> (raw)
Nathan,
I find myself performing similar actions to you: using git add -p to stage hunks, sometimes editing the staged patch; and keeping mental notes of things I wanted to revert, sometimes changing them in the editor in another window, and sometimes reverting them after the add session with git checkout -p).
The interactive staging-and-editing tool could be improved, but I'm not sure that tool should be called 'git add -p'. git add doesn't touch the working tree — at least I hope not, because I wouldn't expect it.
But I eagerly support more discussion. If someone does want to add this feature to "git add -p" (or named differently), I'll add a request for another letter (perhaps '!') to edit the hunk in the working tree.
Jonathon Mah
me@JonathonMah.com
next reply other threads:[~2012-11-08 9:12 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-08 8:57 Jonathon Mah [this message]
2012-11-08 12:00 ` Revert option for git add --patch Nguyen Thai Ngoc Duy
2012-11-08 15:15 ` Jeff King
[not found] ` <CAPXHQbPrjZ_Ezi3RkHny-fW0=mQCTmX9NVJfgUh7P-Xx9pgBcg@mail.gmail.com>
2012-11-08 20:04 ` Jeff King
2012-11-09 14:09 ` Bogolisk
[not found] <CAPXHQbOxNG0XN80rH6mM6iSVtCtU26Yio_XQ=5ofBHBpZN3VyQ@mail.gmail.com>
2012-11-07 23:54 ` Nathan Broadbent
2012-11-08 1:00 ` Simon Rozet
2012-11-08 8:46 ` Michal Kiedrowicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=EE89F0A1-1C07-4597-B654-035F657AD09F@me.com \
--to=jmah@me.com \
--cc=git@vger.kernel.org \
--cc=nathan.f77@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).