Git Stash brake splitIndex

From: Son Luong Ngoc <sluongng@gmail.com>
To: git@vger.kernel.org
Cc: Junio C Hamano <gitster@pobox.com>
Subject: Git Stash brake splitIndex
Date: Tue, 28 Apr 2020 15:19:06 +0200	[thread overview]
Message-ID: <EED2CFF1-5BEF-429D-AB99-AD148A867614@gmail.com> (raw)

Hi folks,

I am on git version 2.26.2.526.g744177e7f7 (latest next)
When you do a git stash while using splitIndex, it seems like the index will get corrupted

Using configs:
core.splitindex=true
splitindex.maxpercentchange=50
splitindex.sharedindexexpire=now

Reproduce steps:

mkdir repo
cd repo && git init
echo a > a
commit -a -m 'add a'
echo b > b
git add b
git stash
Saved working directory and index state WIP on master: 1955b62 add a
fatal: .git/sharedindex.8ddd8dad6ccb4858f27d4ff20f4d8bf6654441e0: index file open failed: No such file or directory

Some traces:
master ~/test/git/repo> GIT_TRACE2=1 GIT_TRACE2_NESTING=5 git stash
15:18:15.442295 common-main.c:48                  version 2.26.2.526.g744177e7f7
15:18:15.442914 common-main.c:49                  start git stash
15:18:15.443284 repository.c:134                  worktree /Users/sluongngoc/test/git/repo
15:18:15.443491 git.c:442                         cmd_name stash (stash)
15:18:15.448579 run-command.c:735                 child_start[0] git update-index --ignore-skip-worktree-entries -z --add --remove --stdin
15:18:15.455972 common-main.c:48                  version 2.26.2.526.g744177e7f7
15:18:15.456514 common-main.c:49                  start /Users/sluongngoc/libexec/git-core/git update-index --ignore-skip-worktree-entries -z --add --remove --stdin
15:18:15.456788 repository.c:134                  worktree /Users/sluongngoc/test/git/repo
15:18:15.456927 git.c:442                         cmd_name update-index (stash/update-index)
15:18:15.458444 git.c:672                         exit elapsed:0.004021 code:0
15:18:15.458457 trace2/tr2_tgt_normal.c:123       atexit elapsed:0.004039 code:0
15:18:15.458774 run-command.c:990                 child_exit[0] pid:1813 code:0 elapsed:0.010169
Saved working directory and index state WIP on master: 1955b62 add a
15:18:15.461082 run-command.c:735                 child_start[1] git reset --hard -q --no-recurse-submodules
15:18:15.467260 common-main.c:48                  version 2.26.2.526.g744177e7f7
15:18:15.467553 common-main.c:49                  start /Users/sluongngoc/libexec/git-core/git reset --hard -q --no-recurse-submodules
15:18:15.467931 repository.c:134                  worktree /Users/sluongngoc/test/git/repo
15:18:15.468071 git.c:442                         cmd_name reset (stash/reset)
15:18:15.468555 usage.c:64                        error .git/sharedindex.8ddd8dad6ccb4858f27d4ff20f4d8bf6654441e0: index file open failed: No such file or directory
fatal: .git/sharedindex.8ddd8dad6ccb4858f27d4ff20f4d8bf6654441e0: index file open failed: No such file or directory
15:18:15.468587 usage.c:68                        exit elapsed:0.002714 code:128
15:18:15.468595 trace2/tr2_tgt_normal.c:123       atexit elapsed:0.002726 code:128
15:18:15.468889 run-command.c:990                 child_exit[1] pid:1814 code:128 elapsed:0.007797
15:18:15.468930 git.c:672                         exit elapsed:0.028400 code:1
15:18:15.468947 trace2/tr2_tgt_normal.c:123       atexit elapsed:0.028418 code:1
exit 1

Cheers,
Son Luong.