From: Jason Gore <Jason.Gore@microsoft.com>
To: "peff@peff.net" <peff@peff.net>,
"sandals@crustytoothpaste.net" <sandals@crustytoothpaste.net>
Cc: "git@vger.kernel.org" <git@vger.kernel.org>,
"newren@gmail.com" <newren@gmail.com>
Subject: RE: Git clean enumerates ignored directories (since 2.27)
Date: Thu, 22 Apr 2021 17:18:19 +0000 [thread overview]
Message-ID: <MN2PR00MB068886B8F36DFC645138DA0489469@MN2PR00MB0688.namprd00.prod.outlook.com> (raw)
In-Reply-To: <YHf+m7vOQumdJXwX@coredump.intra.peff.net>
Sorry to add noise to this thread but since the github issue was closed I wanted to make sure I'm not missing any updates here. Would any updates come through on this thread? Thanks!
-----Original Message-----
From: Jeff King <peff@peff.net>
Sent: Thursday, April 15, 2021 1:52 AM
To: brian m. carlson <sandals@crustytoothpaste.net>
Cc: Jason Gore <Jason.Gore@microsoft.com>; git@vger.kernel.org; Elijah Newren <newren@gmail.com>
Subject: Re: Git clean enumerates ignored directories (since 2.27)
On Wed, Apr 14, 2021 at 10:56:14PM +0000, brian m. carlson wrote:
> ----
> #!/bin/sh
>
> git init test-repo
> cd test-repo
> longname="directory"
> touch "$longname.txt"
> last=400
> for x in $(seq 1 $last); do
> mkdir "x$longname$x"
> mv directory* "x$longname$x"
> mv "x$longname$x" "$longname$x"
> done
> git clean -ffdxn -e directory$last
> ----
>
> When it fails, it will complain that it wasn't able to open the
> directory. It still exits zero, however.
>
> I haven't bisected this, so I don't know if those patches are related
> to the problem or not. I'm a little short on time today to
> investigate further, but hopefully this can get someone on the right
> path with a modified version and git bisect run if nothing else.
It bisects to 8d92fb2927 (dir: replace exponential algorithm with a linear one, 2020-04-01). I won't pretend to understand everything going on in that commit, though.
-Peff
next prev parent reply other threads:[~2021-04-22 17:18 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-14 17:17 Git clean enumerates ignored directories (since 2.27) Jason Gore
2021-04-14 22:56 ` brian m. carlson
2021-04-15 8:51 ` Jeff King
2021-04-22 17:18 ` Jason Gore [this message]
2021-04-22 17:24 ` Elijah Newren
2021-05-07 4:08 ` Elijah Newren
2021-05-07 2:31 ` Elijah Newren
2021-05-07 3:25 ` Jeff King
2021-05-07 3:43 ` Jeff King
2021-05-07 3:44 ` Elijah Newren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MN2PR00MB068886B8F36DFC645138DA0489469@MN2PR00MB0688.namprd00.prod.outlook.com \
--to=jason.gore@microsoft.com \
--cc=git@vger.kernel.org \
--cc=newren@gmail.com \
--cc=peff@peff.net \
--cc=sandals@crustytoothpaste.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).