From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Junio C Hamano <junkio@cox.net>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] fmt-patch: Support --attach
Date: Sat, 20 May 2006 19:51:26 +0200 (CEST) [thread overview]
Message-ID: <Pine.LNX.4.63.0605201945110.32590@wbgn013.biozentrum.uni-wuerzburg.de> (raw)
In-Reply-To: <7v4pzk3831.fsf@assigned-by-dhcp.cox.net>
Hi,
On Sat, 20 May 2006, Junio C Hamano wrote:
> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
>
> > I only changed the "From " line (note the missing ":") to match the output
> > from git-format-patch.sh.
>
> Not a big deal, but I was hoping you would keep the inception
> date of git (April one) in the final version ;-). The September
> date is totally a random date and does not have any
> significance.
Actually, I just tested something: pine seems to be confused when parsing
a "From " line where the day of month is only one digit without two
leading digits. I don't care.
> Anyway, with this change (and a lot of testing ;-) I think we
> can replace the script with built-in. Thanks.
There are two options missing: --signoff and --check.
--signoff is my fault: it is probably a good thing to drop it from
format-patch, and only leave it in applymbox.
As for --check: how about having yet another diff "format":
DIFF_FORMAT_CHECK? Instead of showing the diff, it only shows the line(s)
which are offending.
Ciao,
Dscho
next prev parent reply other threads:[~2006-05-20 17:51 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-05-20 13:40 [PATCH] fmt-patch: Support --attach Johannes Schindelin
2006-05-20 14:16 ` Jakub Narebski
2006-05-20 17:10 ` Johannes Schindelin
2006-05-20 17:43 ` Junio C Hamano
2006-05-20 17:51 ` Johannes Schindelin [this message]
2006-05-20 18:00 ` Junio C Hamano
2006-05-20 20:23 ` Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.63.0605201945110.32590@wbgn013.biozentrum.uni-wuerzburg.de \
--to=johannes.schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=junkio@cox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).