From: Linus Torvalds <torvalds@osdl.org>
To: "H. Peter Anvin" <hpa@zytor.com>
Cc: Junio C Hamano <junkio@cox.net>,
Morten Welinder <mwelinder@gmail.com>,
git@vger.kernel.org
Subject: Re: Usage of isspace and friends
Date: Thu, 13 Oct 2005 08:56:27 -0700 (PDT) [thread overview]
Message-ID: <Pine.LNX.4.64.0510130847190.15297@g5.osdl.org> (raw)
In-Reply-To: <434E8117.3090102@zytor.com>
On Thu, 13 Oct 2005, H. Peter Anvin wrote:
>
> Because of the special case of 255 which looks indistinguishable from EOF,
> therefore making it required?
Yeah, and I agree, that was a mistake. It could have been fixed by making
EOF be MIN_INT (or any other value outside the range of either "unsigned
char" or "signed char" - preferably still negative), but there are
probably programs that depend on it being -1.
The stupid thing I just posted doesn't care. It happens to return 0 for
EOF for all cases, but that's a side effect of (a) not doing locales (so
255 is never printable or alpha) and (b) not even implementing iscntrl().
In general, the rule for ctype and EOF _should_ have been that it's part
of an acceptable input range, but that the return value is undefined ;)
(Which would allow you to test EOF later, and not worry about any faults).
Linus
next prev parent reply other threads:[~2005-10-13 15:56 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-10-12 1:40 Usage of isspace and friends Morten Welinder
2005-10-13 6:49 ` Junio C Hamano
2005-10-13 8:29 ` Antti-Juhani Kaijanaho
2005-10-13 13:27 ` H. Peter Anvin
2005-10-13 15:44 ` Junio C Hamano
2005-10-13 15:04 ` Linus Torvalds
2005-10-13 15:45 ` H. Peter Anvin
2005-10-13 15:56 ` Linus Torvalds [this message]
2005-10-13 16:07 ` H. Peter Anvin
2005-10-13 15:46 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0510130847190.15297@g5.osdl.org \
--to=torvalds@osdl.org \
--cc=git@vger.kernel.org \
--cc=hpa@zytor.com \
--cc=junkio@cox.net \
--cc=mwelinder@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).