From: Linus Torvalds <torvalds@osdl.org>
To: Jason Riedy <ejr@EECS.Berkeley.EDU>
Cc: Junio C Hamano <junkio@cox.net>, git@vger.kernel.org
Subject: Re: [PATCH] Use sigaction and SA_RESTART in read-tree.c; add option in Makefile.
Date: Sun, 2 Apr 2006 18:02:28 -0700 (PDT) [thread overview]
Message-ID: <Pine.LNX.4.64.0604021752500.23419@g5.osdl.org> (raw)
In-Reply-To: <17063.1144016974@lotus.CS.Berkeley.EDU>
On Sun, 2 Apr 2006, Jason Riedy wrote:
>
> Might as well ape the sigaction change in read-tree.c to avoid
> the same potential problems.
Looks good. I didn't realize we had the exact same code duplicated. I
guess it's small enough that there isn't a huge win in moving it to some
common file..
Does somebody have access to Solaris to verify that this all actually does
fix it? I obviously believe it will, since this just explains the symptoms
to a tee, but it would still be good to have an actual confirmation by
somebody who has access to a Solaris environment.
> Also add a NO_SA_RESTART option in the Makefile in case someone
> doesn't have SA_RESTART but does restart (maybe older HP/UX?).
> We want the builder to chose this specifically in case the
> system both lacks SA_RESTART and does not restart stdio calls;
> a compat #define in git-compat-utils.h would silently allow
> broken systems.
I do believe that we already require POSIX.2 functionality (regex,
fnmatch, C90 compiler), which implies that git probably wouldn't compile
anyway on things that are _really_ ancient.
I think SA_RESTART was part of the original POSIX.1 specs, so anybody that
doesn't have it is likely to not have a lot of other things we rely on
too. There are other SA_* flags that aren't as standard, but I'd expect
SA_RESTART to be everywhere (or it likely doesn't have sigaction() at
all..).
But hey, I certainly don't have really old HP-UX to test either.
Linus
next prev parent reply other threads:[~2006-04-03 1:03 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-02 10:41 Solaris cloning woes partly diagnosed Junio C Hamano
2006-04-02 18:33 ` Linus Torvalds
2006-04-02 19:10 ` Jason Riedy
2006-04-02 19:22 ` Linus Torvalds
2006-04-02 19:18 ` Linus Torvalds
2006-04-02 19:52 ` Jason Riedy
2006-04-02 20:28 ` Linus Torvalds
2006-04-02 20:31 ` [PATCH 2/2] pack-objects: be incredibly anal about stdio semantics Linus Torvalds
2006-04-02 21:09 ` Junio C Hamano
2006-04-02 21:21 ` Linus Torvalds
2006-04-02 22:12 ` Jason Riedy
2006-04-02 22:58 ` Linus Torvalds
2006-04-02 22:29 ` [PATCH] Use sigaction and SA_RESTART in read-tree.c; add option in Makefile Jason Riedy
2006-04-03 1:02 ` Linus Torvalds [this message]
2006-04-03 4:20 ` Junio C Hamano
2006-04-03 4:40 ` Linus Torvalds
2006-04-03 3:06 ` Solaris cloning woes partly diagnosed Linus Torvalds
2006-04-04 18:21 ` H. Peter Anvin
2006-04-04 8:47 ` [RFH] Solaris cloning woes Junio C Hamano
2006-04-04 18:53 ` Jason Riedy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0604021752500.23419@g5.osdl.org \
--to=torvalds@osdl.org \
--cc=ejr@EECS.Berkeley.EDU \
--cc=git@vger.kernel.org \
--cc=junkio@cox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).