git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Đoàn Trần Công Danh" <congdanhqx@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: "Érico Rolim" <erico.erc@gmail.com>, git@vger.kernel.org
Subject: Re: [BUG] In git-log, --name-status flag overrides the --patch flag
Date: Thu, 24 Dec 2020 06:54:59 +0700	[thread overview]
Message-ID: <X+PY0/yTwrXjVRvb@danh.dev> (raw)
In-Reply-To: <xmqq5z4vm0vt.fsf@gitster.c.googlers.com>

On 2020-12-21 11:09:58-0800, Junio C Hamano <gitster@pobox.com> wrote:
> Đoàn Trần Công Danh  <congdanhqx@gmail.com> writes:
> 
> > On 2020-12-20 01:23:05-0300, Érico Rolim <erico.erc@gmail.com> wrote:
> >> Hi!
> >> 
> >> When using the command
> >> 
> >>   git log --patch --name-status
> >> 
> >> It seems the name-status flag somehow overrides the patch flag, by which I mean
> >> that I get the same output as simply running
> >> 
> >>   git log --name-status
> >> 
> >> It would be nice for the combination of these two flags to work, as it would
> >> allow one to view both a summary of changed files as well as the changes
> >> themselves, at the same time.
> >
> > I'm not arguing if this your expectation is make sense or not,
> > however, the Documentation says something about "Show only"...
> 
> Perhaps the documentation would need to be clarified?

Honestly, I think documentation is fine, "Show only"... should mean
only.

>
> I suspect
> this is not very useful combination [*1*] and if this were years
> ago, I would suggest making the command line error out, instead of
> silently ignore one and keep the other one in effect.

Although, I don't have strong opinion on this combination,
I would say yes, and we should error out for other combination like
--name-status --patch too. And Érico, in a reply to me, said he would
prefer seeing an error instead of silencely discard one option.
I'll look into the implementation in this weekend.

> 
> 
> [Footnote]
> 
> *1* "--patch --stat --summmary" was designed as the standard "both a
>     summary as well as the changes".

-- 
Danh

      reply	other threads:[~2020-12-23 23:56 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-20  4:23 [BUG] In git-log, --name-status flag overrides the --patch flag Érico Rolim
2020-12-21 13:16 ` Đoàn Trần Công Danh
2020-12-21 19:09   ` Junio C Hamano
2020-12-23 23:54     ` Đoàn Trần Công Danh [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=X+PY0/yTwrXjVRvb@danh.dev \
    --to=congdanhqx@gmail.com \
    --cc=erico.erc@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).