From: Taylor Blau <me@ttaylorr.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Elijah Newren <newren@gmail.com>, Git Mailing List <git@vger.kernel.org>
Subject: Re: What's cooking in git.git (Dec 2020, #01; Tue, 8)
Date: Wed, 9 Dec 2020 18:02:53 -0500 [thread overview]
Message-ID: <X9FXnWLFT/2v8acE@nand.local> (raw)
In-Reply-To: <xmqqy2i738x1.fsf@gitster.c.googlers.com>
On Tue, Dec 08, 2020 at 08:22:50PM -0800, Junio C Hamano wrote:
> Elijah Newren <newren@gmail.com> writes:
>
> > On Tue, Dec 8, 2020 at 5:37 PM Junio C Hamano <gitster@pobox.com> wrote:
> >>
> >> * en/diffcore-rename (2020-12-07) 5 commits
> >> - diffcore-rename: simplify and accelerate register_rename_src()
> >> - diffcore-rename: reduce jumpiness in progress counters
> >> - diffcore-rename: rename num_create to num_targets
> >> - diffcore-rename: remove unnecessary if-clause
> >> - diffcore-rename: avoid usage of global in too_many_rename_candidates()
> >
> > Curious. I submitted 7 patches for this series.
>
> Yeah, I wanted to leave the "hard-to-digest" one out, and queued the
> "relatively easy to review" ones. Even then, I ran out of time to
> read these early 6 (and nobody else seems to have done so, either).
I reviewed all seven, and would be happy to see these merged up. The
first five were all pretty trivial to review, and the last two
definitely required more attention, but I couldn't spot any correctness
issues with them.
It might not hurt to get another set of eyes on 6/7 and 7/7, so if you
just want to take the first 1-5/7 for now, that'd be fine with me, too.
Thanks,
Taylor
next prev parent reply other threads:[~2020-12-09 23:03 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-09 1:31 What's cooking in git.git (Dec 2020, #01; Tue, 8) Junio C Hamano
2020-12-09 1:41 ` Taylor Blau
2020-12-10 2:02 ` Jonathan Tan
2020-12-09 2:45 ` Elijah Newren
2020-12-09 4:22 ` Junio C Hamano
2020-12-09 23:02 ` Taylor Blau [this message]
2020-12-10 0:57 ` Junio C Hamano
2020-12-10 2:57 ` Jonathan Tan
2020-12-09 14:09 ` fc/pull-merge-rebase, was " Johannes Schindelin
2020-12-09 21:28 ` Junio C Hamano
2020-12-10 0:31 ` Felipe Contreras
2020-12-10 4:40 ` Johannes Schindelin
2020-12-10 4:46 ` Johannes Schindelin
2020-12-10 15:11 ` Felipe Contreras
2020-12-10 15:27 ` Theodore Y. Ts'o
2020-12-10 18:28 ` Junio C Hamano
2020-12-11 1:33 ` Felipe Contreras
2020-12-11 7:17 ` Junio C Hamano
2020-12-11 14:10 ` Felipe Contreras
2020-12-11 22:09 ` Theodore Y. Ts'o
2020-12-12 0:43 ` Felipe Contreras
2020-12-10 0:27 ` Felipe Contreras
2020-12-11 5:59 ` Junio C Hamano
2020-12-09 14:11 ` js/init-defaultbranch-advice, " Johannes Schindelin
2020-12-09 21:57 ` Junio C Hamano
2020-12-10 4:54 ` Johannes Schindelin
2020-12-10 18:33 ` Junio C Hamano
2020-12-11 0:03 ` Felipe Contreras
2020-12-10 3:56 ` bc/rev-parse-path-format, " Johannes Schindelin
2020-12-10 18:34 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=X9FXnWLFT/2v8acE@nand.local \
--to=me@ttaylorr.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=newren@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).