Re: [PATCH v3 0/4] Makefile: untangle bin-wrappers/% rule complexity

[Taylor Blau <me@ttaylorr.com>]

On Mon, Oct 31, 2022 at 11:28:05PM +0100, Ævar Arnfjörð Bjarmason wrote:
> Ævar Arnfjörð Bjarmason (4):
>   Makefile: factor sed-powered '#!/bin/sh' munging into a variable
>   Makefile: define "TEST_{PROGRAM,OBJS}" variables earlier
>   Makefile: rename "test_bindir_programs" variable, pre-declare
>   Makefile: simplify $(test_bindir_programs) rule by splitting it up
>
>  Makefile | 70 +++++++++++++++++++++++++++++++++++++++++---------------
>  1 file changed, 51 insertions(+), 19 deletions(-)

Thanks. I replaced the earlier round with this one and pushed the result
out to ttaylorr/git.

But having read the topic over again, I have to say that I also find the
pre-existing behavior to be as expected. "make bin-wrappers/git"
produces its target as expected, but the target is useless because the
relationship it has with "git" is a runtime dependency, not a Make-time
dependency.

So I'm not inclined to pick this one up, honestly. Perhaps other
reviewers feel differently.


Thanks,
Taylor