From: Jeff King <peff@peff.net>
To: Taylor Blau <me@ttaylorr.com>
Cc: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>, git@vger.kernel.org
Subject: Re: ab/make-bin-wrappers (was: What's cooking in git.git (Nov 2022, #01; Thu, 3))
Date: Wed, 9 Nov 2022 09:04:09 -0500 [thread overview]
Message-ID: <Y2uzWbl3M235Jlu+@coredump.intra.peff.net> (raw)
In-Reply-To: <Y2rPrNz6BD6DlRcO@nand.local>
On Tue, Nov 08, 2022 at 04:52:44PM -0500, Taylor Blau wrote:
> > I don't have any strong opinion on that. I read the v2 cover letter, was
> > skeptical/confused of the motivation, and didn't go much further.
> >
> > Your explanation in the linked email is that there are _other_ reasons
> > to do this refactoring, but I don't have any knowledge there that would
> > add to the review. My gut is still that building bin-wrappers/foo
> > doesn't need to depend on foo, but if it's one line, I don't care that
> > much either way. If it was 50 lines of complicated Makefile refactoring,
> > then would probably not be worth it.
>
> Isn't this topic exactly the latter? IOW:
>
> $ git diff --stat master...ab/make-bin-wrappers
> Makefile | 72 ++++++++++++++++++++++++++++++++++++++++++++++++++++--------------------
> 1 file changed, 52 insertions(+), 20 deletions(-)
>
> ...maybe that was exactly your point ;-).
Sorry, I perhaps could have made the last sentence more clear as:
If it was 50 lines of complicated Makefile refactoring _just_ to have
"make bin-wrappers/foo" depend on "foo", it would not be worth it. But
if it is doing something else, it might be. I don't have a strong
opinion because I haven't (and don't want to have) looked into that
"something else".
-Peff
next prev parent reply other threads:[~2022-11-09 14:04 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-04 1:05 What's cooking in git.git (Nov 2022, #01; Thu, 3) Taylor Blau
2022-11-05 0:21 ` Philip Oakley
2022-11-05 0:26 ` Taylor Blau
2022-11-07 12:19 ` Philip Oakley
2022-11-08 21:49 ` Taylor Blau
2022-11-07 14:28 ` ab/config-multi-and-nonbool (was: What's cooking in git.git (Nov 2022, #01; Thu, 3)) Ævar Arnfjörð Bjarmason
2022-11-07 14:33 ` ab/make-bin-wrappers " Ævar Arnfjörð Bjarmason
2022-11-08 14:27 ` Jeff King
2022-11-08 21:52 ` Taylor Blau
2022-11-09 14:04 ` Jeff King [this message]
2022-11-07 21:14 ` ab/coccicheck-incremental " Ævar Arnfjörð Bjarmason
2022-11-08 21:53 ` Taylor Blau
2022-11-07 21:24 ` ab/sha-makefile-doc " Ævar Arnfjörð Bjarmason
2022-11-08 14:13 ` ab/submodule-helper-prep-only " Ævar Arnfjörð Bjarmason
2022-11-08 22:04 ` Taylor Blau
2022-11-08 14:14 ` ab/cmake-nix-and-ci " Ævar Arnfjörð Bjarmason
2022-11-08 14:49 ` Phillip Wood
2022-11-08 14:22 ` ab/misc-hook-submodule-run-command " Ævar Arnfjörð Bjarmason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y2uzWbl3M235Jlu+@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=me@ttaylorr.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).