archive mirror
 help / color / mirror / Atom feed
From: Taylor Blau <>
Cc:, "Ævar Arnfjörð Bjarmason" <>,
Subject: Re: [PATCH v2] maintenance --unregister: fix uninit'd data use & -Wdeclaration-after-statement
Date: Tue, 15 Nov 2022 13:54:45 -0500	[thread overview]
Message-ID: <Y3PgdXp30kLA15E+@nand.local> (raw)
In-Reply-To: <>

On Tue, Nov 15, 2022 at 06:00:45PM +0000, wrote:
> November 15, 2022 10:35 AM, "Taylor Blau" <> wrote:
> > It was human error on my part. Please let me know if the result in
> > 'next' now is OK to you.
> Had a look and I'm just wondering if we're sure it's alright to clear
> the configset before using the list we found in it. Doesn't that list
> point into the configset?

It does. I should not have trusted the incoming patch so blindly. See:

for a fixup on top.


      reply	other threads:[~2022-11-15 18:54 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-15  8:04 [PATCH] builtin/gc.c: fix -Wdeclaration-after-statement Ævar Arnfjörð Bjarmason
2022-11-15  9:37 ` Johannes Schindelin
2022-11-15  9:54   ` Johannes Schindelin
2022-11-15 16:05     ` Ævar Arnfjörð Bjarmason
2022-11-15 16:04 ` [PATCH v2] maintenance --unregister: fix uninit'd data use & -Wdeclaration-after-statement Ævar Arnfjörð Bjarmason
2022-11-15 17:34   ` Taylor Blau
2022-11-15 16:32 ` ronan
2022-11-15 17:35   ` Taylor Blau
2022-11-15 18:00   ` ronan
2022-11-15 18:54     ` Taylor Blau [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y3PgdXp30kLA15E+@nand.local \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).