From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] format-patch: unleak "-v <num>"
Date: Mon, 16 Jan 2023 14:51:10 -0500 [thread overview]
Message-ID: <Y8WqruNU5Z6ewJte@coredump.intra.peff.net> (raw)
In-Reply-To: <xmqqpmbecoom.fsf@gitster.g>
On Mon, Jan 16, 2023 at 10:35:53AM -0800, Junio C Hamano wrote:
> > The word "unleak" in the subject made me think about UNLEAK(), so this
> > is a small tangent. This is exactly the kind of case that I designed
> > UNLEAK() for, because the solution really is "while you are assigning to
> > X, also keep a copy of the pointer in Y to be freed later".
>
> Yup. I was originally planning to use UNLEAK(), but it felt ugly to
> UNLEAK(rev.subject_prefix), as it stores borrowed pointer sometimes
> and owned pointer some other times, which is the exact reason why I
> started looking for a clean way to plug this leak. So I ended up
> with declaring that the member should only store a borrowed pointer.
That's actually one of the nice things about UNLEAK(). It is OK to
over-mark something that may or may not be allocated.
> The first sentence needs to be rephrased, as it does not make much
> sense to have something usually be X and always be X at the same
> time (I'd just remove "always" from there).
Yep, agreed.
-Peff
prev parent reply other threads:[~2023-01-16 19:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-15 8:03 [PATCH] format-patch: unleak "-v <num>" Junio C Hamano
2023-01-16 17:30 ` Jeff King
2023-01-16 18:35 ` Junio C Hamano
2023-01-16 19:51 ` Jeff King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y8WqruNU5Z6ewJte@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).