From: Jeff King <peff@peff.net>
To: Taylor Blau <me@ttaylorr.com>
Cc: Jacob Vosmaer <jacob@gitlab.com>, Git Mailing List <git@vger.kernel.org>
Subject: Re: [PATCH 1/1] ls-refs.c: minimize number of refs visited
Date: Tue, 19 Jan 2021 17:52:03 -0500 [thread overview]
Message-ID: <YAdik+z5yj2XU0ti@coredump.intra.peff.net> (raw)
In-Reply-To: <YAdb6GmVXWLEGkP1@nand.local>
On Tue, Jan 19, 2021 at 05:23:36PM -0500, Taylor Blau wrote:
> > Having now looked carefully at the ls-refs code, it's a pure
> > prefix-match, too. So I think we _could_ rely on for_each_fullref_in()
> > returning us the correct full results, and not checking it further in
> > send_ref(). But I kind of like keeping it there as an extra check (and
> > one which could in theory grow more logic later).
>
> Hmm. What if the caller asks for:
>
> ref-prefix refs/tags/a
> ref-prefix refs/tags/b
>
> ?
>
> The LCP between those two is refs/tags, so send_ref() will presumably
> get lots of reuslts that it doesn't care about (assuming there are tags
> besides a and b).
Oh, you're right, of course. Ignore me. :)
-Peff
next prev parent reply other threads:[~2021-01-19 22:53 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-19 14:42 [PATCH 0/1] ls-refs.c: minimize number of refs visited Jacob Vosmaer
2021-01-19 14:42 ` [PATCH 1/1] " Jacob Vosmaer
2021-01-19 16:12 ` Taylor Blau
2021-01-19 17:42 ` Jacob Vosmaer
2021-01-19 18:19 ` [PATCH 0/2] ls-refs: only traverse through longest common ref prefix Taylor Blau
2021-01-19 18:19 ` [PATCH 1/2] refs: expose 'for_each_fullref_in_prefixes' Taylor Blau
2021-01-19 18:19 ` [PATCH 2/2] ls-refs.c: traverse longest common ref prefix Taylor Blau
2021-01-19 23:09 ` Jeff King
2021-01-19 23:52 ` Taylor Blau
2021-01-20 0:08 ` Jeff King
2021-01-20 11:00 ` Jacob Vosmaer
2021-01-20 16:04 ` [PATCH v2 0/3] ls-refs: traverse prefixes of disjoint "ref-prefix" sets Taylor Blau
2021-01-20 16:04 ` [PATCH v2 1/3] refs: expose 'for_each_fullref_in_prefixes' Taylor Blau
2021-01-20 19:56 ` Jeff King
2021-01-20 20:12 ` Taylor Blau
2021-01-23 2:59 ` Junio C Hamano
2021-01-25 1:35 ` Taylor Blau
2021-01-20 16:04 ` [PATCH v2 2/3] ls-refs.c: initialize 'prefixes' before using it Taylor Blau
2021-01-20 19:58 ` Jeff King
2021-01-20 20:13 ` Taylor Blau
2021-01-20 21:50 ` Jacob Vosmaer
2021-01-20 16:04 ` [PATCH v2 3/3] ls-refs.c: traverse prefixes of disjoint "ref-prefix" sets Taylor Blau
2021-01-23 17:55 ` [PATCH v2 0/3] ls-refs: " Junio C Hamano
2021-01-19 19:09 ` [PATCH 1/1] ls-refs.c: minimize number of refs visited Taylor Blau
2021-01-19 21:59 ` Jeff King
2021-01-19 22:15 ` Jeff King
2021-01-19 22:23 ` Taylor Blau
2021-01-19 22:52 ` Jeff King [this message]
2021-01-19 22:59 ` Jeff King
2021-01-19 23:02 ` Taylor Blau
2021-01-19 22:53 ` Jeff King
2021-01-19 23:00 ` Taylor Blau
2021-01-19 23:11 ` Jeff King
2021-01-20 10:40 ` Jacob Vosmaer
2021-01-20 10:44 ` Jacob Vosmaer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YAdik+z5yj2XU0ti@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=jacob@gitlab.com \
--cc=me@ttaylorr.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).