From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F2099C433E0 for ; Sat, 30 Jan 2021 09:07:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C10A164E27 for ; Sat, 30 Jan 2021 09:07:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229619AbhA3JH4 (ORCPT ); Sat, 30 Jan 2021 04:07:56 -0500 Received: from cloud.peff.net ([104.130.231.41]:41422 "EHLO cloud.peff.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233863AbhA3JHg (ORCPT ); Sat, 30 Jan 2021 04:07:36 -0500 Received: (qmail 16594 invoked by uid 109); 30 Jan 2021 08:41:32 -0000 Received: from Unknown (HELO peff.net) (10.0.1.2) by cloud.peff.net (qpsmtpd/0.94) with ESMTP; Sat, 30 Jan 2021 08:41:32 +0000 Authentication-Results: cloud.peff.net; auth=none Received: (qmail 23248 invoked by uid 111); 30 Jan 2021 08:41:32 -0000 Received: from coredump.intra.peff.net (HELO sigill.intra.peff.net) (10.0.0.2) by peff.net (qpsmtpd/0.94) with (TLS_AES_256_GCM_SHA384 encrypted) ESMTPS; Sat, 30 Jan 2021 03:41:32 -0500 Authentication-Results: peff.net; auth=none Date: Sat, 30 Jan 2021 03:41:31 -0500 From: Jeff King To: Taylor Blau Cc: git@vger.kernel.org, dstolee@microsoft.com, gitster@pobox.com, jrnieder@gmail.com Subject: Re: [PATCH v3 06/10] Documentation/config/pack.txt: advertise 'pack.writeReverseIndex' Message-ID: References: <7e29f2d3a08c42b1e8368c4a2f52a11cc47ee959.1611617820.git.me@ttaylorr.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Thu, Jan 28, 2021 at 08:17:40PM -0500, Taylor Blau wrote: > On Thu, Jan 28, 2021 at 07:30:56PM -0500, Jeff King wrote: > > On Mon, Jan 25, 2021 at 06:37:34PM -0500, Taylor Blau wrote: > > > > > +pack.writeReverseIndex:: > > > + When true, git will write a corresponding .rev file (see: > > > + link:../technical/pack-format.html[Documentation/technical/pack-format.txt]) > > > + for each new packfile that it writes in all places except for > > > + linkgit:git-fast-import[1] and in the bulk checkin mechanism. > > > + Defaults to false. > > > > We may want to teach fast-import about this, too, but I think it's OK to > > draw the line here for now (it's already reasonably well known that the > > generated packs aren't amazing and benefit from repacking). > > Maybe this was worth explaining in the documentation, but this choice > was intentional. I'm not aware of any use-case that keeps the packs > generated by fast-import around for very long (i.e., I'd expect any 'git > fast-import' to be pretty quickly followed by a 'git repack -ad'), so I > don't think we'd want to spend time generating a reverse index for a > pack structure that we're about to immediately discard. One case where I imagine they are kept is in remote-helpers that use the import/export mechanism (e.g., something interacting with remote-hg). I suspect people there just live with the somewhat lousy packs, and then perhaps occasionally "git repack -adf". That would give them .rev files then, too. But as I said, I think it's OK to ignore this for now. If somebody with an interest in fast-import wants to add support later, they can. -Peff