From: Jeff King <peff@peff.net>
To: Albert Cui via GitGitGadget <gitgitgadget@gmail.com>
Cc: git@vger.kernel.org, Albert Cui <albertqcui@gmail.com>
Subject: Re: [PATCH] fetch: show progress for packfile uri downloads
Date: Wed, 17 Mar 2021 15:21:51 -0400 [thread overview]
Message-ID: <YFJWz5yIGng+a16k@coredump.intra.peff.net> (raw)
In-Reply-To: <pull.907.git.1616007794513.gitgitgadget@gmail.com>
On Wed, Mar 17, 2021 at 07:03:13PM +0000, Albert Cui via GitGitGadget wrote:
> From: Albert Cui <albertqcui@gmail.com>
>
> Git appears to hang when downloading packfiles as this part of the
> fetch is silent, causing user confusion. This change implements
> progress for the number of packfiles downloaded; a progress display
> for bytes would involve deeper changes at the http-fetch layer
> instead of fetch-pack, the caller.
I think this is an improvement, but I agree that a real byte display
would be much better. I actually worked on this a long time ago for a
very similar feature that we never quite pushed over the finish line.
See patches 11 and 12 here:
https://lore.kernel.org/git/20111110074330.GA27925@sigill.intra.peff.net/
(it might need some of the earlier refactoring, too, I'm not sure; and
quite likely will need forward-porting as it has been 10 years).
-Peff
next prev parent reply other threads:[~2021-03-17 19:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-17 19:03 [PATCH] fetch: show progress for packfile uri downloads Albert Cui via GitGitGadget
2021-03-17 19:21 ` Jeff King [this message]
2021-03-17 19:31 ` Junio C Hamano
2021-04-09 22:44 ` [PATCH v2] " Albert Cui via GitGitGadget
2021-04-11 1:30 ` Junio C Hamano
2021-06-30 23:09 ` Jonathan Nieder
2021-04-10 8:31 ` [PATCH] " Ævar Arnfjörð Bjarmason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YFJWz5yIGng+a16k@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=albertqcui@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).