From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E0691C43461 for ; Fri, 9 Apr 2021 18:06:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BB572611AB for ; Fri, 9 Apr 2021 18:06:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234481AbhDISHG (ORCPT ); Fri, 9 Apr 2021 14:07:06 -0400 Received: from cloud.peff.net ([104.130.231.41]:46540 "EHLO cloud.peff.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234453AbhDISHF (ORCPT ); Fri, 9 Apr 2021 14:07:05 -0400 Received: (qmail 616 invoked by uid 109); 9 Apr 2021 18:06:52 -0000 Received: from Unknown (HELO peff.net) (10.0.1.2) by cloud.peff.net (qpsmtpd/0.94) with ESMTP; Fri, 09 Apr 2021 18:06:52 +0000 Authentication-Results: cloud.peff.net; auth=none Received: (qmail 14591 invoked by uid 111); 9 Apr 2021 18:06:52 -0000 Received: from coredump.intra.peff.net (HELO sigill.intra.peff.net) (10.0.0.2) by peff.net (qpsmtpd/0.94) with (TLS_AES_256_GCM_SHA384 encrypted) ESMTPS; Fri, 09 Apr 2021 14:06:52 -0400 Authentication-Results: peff.net; auth=none Date: Fri, 9 Apr 2021 14:06:51 -0400 From: Jeff King To: =?utf-8?B?w4Z2YXIgQXJuZmrDtnLDsA==?= Bjarmason Cc: git@vger.kernel.org, Junio C Hamano , Johannes Schindelin , Taylor Blau , Elijah Newren Subject: Re: [PATCH 1/6] object.c: stop supporting len == -1 in type_from_string_gently() Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Fri, Apr 09, 2021 at 10:32:49AM +0200, Ævar Arnfjörð Bjarmason wrote: > diff --git a/object.c b/object.c > index 7fdca3ed1e..88de01e5ac 100644 > --- a/object.c > +++ b/object.c > @@ -39,9 +39,6 @@ int type_from_string_gently(const char *str, ssize_t len, int gentle) > { > int i; > > - if (len < 0) > - len = strlen(str); > - The "ssize_t len" in the parameters could become a size_t now, right? Not strictly necessary, but in theory it may help static analysis catch a caller who mistakenly tries to pass -1 (though in practice I suspect it does not help that much, because any of gcc's sign-conversion warnings generate far too much noise to be useful with our current codebase). -Peff